This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add types to the library #92
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dbabee7
feat: add types to the library
Gozala d7b7683
chore: workaround ts bug
Gozala 0b45586
chore: move sinon to dev deps
Gozala 38dc03d
fix: small tweaks
hugomrdias 32e2b98
fix: err-code and github
hugomrdias ed2fbdb
fix: feedback
hugomrdias 4c66bb0
chore: remove gh url
achingbrain 38120bd
chore: add sinon types
achingbrain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
blank_issues_enabled: false | ||
contact_links: | ||
- name: Getting Help on IPFS | ||
url: https://ipfs.io/help | ||
about: All information about how and where to get help on IPFS. | ||
- name: IPFS Official Forum | ||
url: https://discuss.ipfs.io | ||
about: Please post general questions, support requests, and discussions here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
name: Open an issue | ||
about: Only for actionable issues relevant to this repository. | ||
title: '' | ||
labels: need/triage | ||
assignees: '' | ||
|
||
--- | ||
<!-- | ||
Hello! To ensure this issue is correctly addressed as soon as possible by the IPFS team, please try to make sure: | ||
- This issue is relevant to this repository's topic or codebase. | ||
- A clear description is provided. It should includes as much relevant information as possible and clear scope for the issue to be actionable. | ||
FOR GENERAL DISCUSSION, HELP OR QUESTIONS, please see the options at https://ipfs.io/help or head directly to https://discuss.ipfs.io. | ||
(you can delete this section after reading) | ||
--> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
# Configuration for welcome - https://github.com/behaviorbot/welcome | ||
|
||
# Configuration for new-issue-welcome - https://github.com/behaviorbot/new-issue-welcome | ||
# Comment to be posted to on first time issues | ||
newIssueWelcomeComment: > | ||
Thank you for submitting your first issue to this repository! A maintainer | ||
will be here shortly to triage and review. | ||
|
||
In the meantime, please double-check that you have provided all the | ||
necessary information to make this process easy! Any information that can | ||
help save additional round trips is useful! We currently aim to give | ||
initial feedback within **two business days**. If this does not happen, feel | ||
free to leave a comment. | ||
|
||
Please keep an eye on how this issue will be labeled, as labels give an | ||
overview of priorities, assignments and additional actions requested by the | ||
maintainers: | ||
|
||
- "Priority" labels will show how urgent this is for the team. | ||
- "Status" labels will show if this is ready to be worked on, blocked, or in progress. | ||
- "Need" labels will indicate if additional input or analysis is required. | ||
|
||
Finally, remember to use https://discuss.ipfs.io if you just need general | ||
support. | ||
|
||
# Configuration for new-pr-welcome - https://github.com/behaviorbot/new-pr-welcome | ||
# Comment to be posted to on PRs from first time contributors in your repository | ||
newPRWelcomeComment: > | ||
Thank you for submitting this PR! | ||
|
||
A maintainer will be here shortly to review it. | ||
|
||
We are super grateful, but we are also overloaded! Help us by making sure | ||
that: | ||
|
||
* The context for this PR is clear, with relevant discussion, decisions | ||
and stakeholders linked/mentioned. | ||
|
||
* Your contribution itself is clear (code comments, self-review for the | ||
rest) and in its best form. Follow the [code contribution | ||
guidelines](https://github.com/ipfs/community/blob/master/CONTRIBUTING.md#code-contribution-guidelines) | ||
if they apply. | ||
|
||
Getting other community members to do a review would be great help too on | ||
complex PRs (you can ask in the chats/forums). If you are unsure about | ||
something, just leave us a comment. | ||
|
||
Next steps: | ||
|
||
* A maintainer will triage and assign priority to this PR, commenting on | ||
any missing things and potentially assigning a reviewer for high | ||
priority items. | ||
|
||
* The PR gets reviews, discussed and approvals as needed. | ||
|
||
* The PR is merged by maintainers when it has been approved and comments addressed. | ||
|
||
We currently aim to provide initial feedback/triaging within **two business | ||
days**. Please keep an eye on any labelling actions, as these will indicate | ||
priorities and status of your contribution. | ||
|
||
We are very grateful for your contribution! | ||
|
||
|
||
# Configuration for first-pr-merge - https://github.com/behaviorbot/first-pr-merge | ||
# Comment to be posted to on pull requests merged by a first time user | ||
# Currently disabled | ||
#firstPRMergeComment: "" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
name: ci | ||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
branches: | ||
- master | ||
|
||
jobs: | ||
check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx aegir lint | ||
- uses: gozala/typescript-error-reporter-action@v1.0.8 | ||
- run: npx aegir build | ||
- run: npx aegir dep-check | ||
- uses: ipfs/aegir/actions/bundle-size@master | ||
name: size | ||
with: | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
test-node: | ||
needs: check | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [windows-latest, ubuntu-latest, macos-latest] | ||
node: [12, 14] | ||
fail-fast: true | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node }} | ||
- run: npm install | ||
- run: npx nyc --reporter=lcov aegir test -t node -- --bail | ||
- uses: codecov/codecov-action@v1 | ||
test-chrome: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx aegir test -t browser -t webworker --bail | ||
test-firefox: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx aegir test -t browser -t webworker --bail -- --browsers FirefoxHeadless | ||
test-electron-main: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx xvfb-maybe aegir test -t electron-main --bail | ||
test-electron-renderer: | ||
needs: check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- run: npm install | ||
- run: npx xvfb-maybe aegir test -t electron-renderer --bail |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: perhaps useful to type hf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but im going to defer that to another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#96