Remove Base1

[fabianhjr]

Base1 takes roughly 255 times more space than the Byte Array it would be representing; it is both computationally and space inefficient and isn't used.

[Stebalien]

This is really just "for completeness". However, I agree that it's entirely useless and would kind of like to remove it as well.

@daviddias any objections?

[daviddias]

I agree with the completeness argument? Also, why bother removing it now?

[Stebalien]

In theory, it frees up a multibase prefix. I think the main issue is that you can't claim to completely implement multibase without it.

[fabianhjr]

I am implementing a multiformats lib but would much rather not implement Base1

[fabianhjr]

Implementation of Base1:

• go-multibase doesn't implement it: https://github.com/multiformats/go-multibase/blob/4cd2fef2843ca7a1fdff9a60c3b2f10b31b489fe/multibase.go#L41-L61

• kotlin-multibase doesn't implement it: https://github.com/changjiashuai/kotlin-multibase/blob/master/src/main/kotlin/io/ipfs/multiformats/multibase/MultiBase.kt#L60

• js-multibase doesn't implement it: https://github.com/multiformats/js-multibase/tree/master/src

• cs-multibase doesn't implement it: https://github.com/multiformats/cs-multibase/tree/master/src/Multiformats.Base

• rust-multibase doesn't implement it: https://github.com/multiformats/rust-multibase/blob/1a1f95da402e51a825f704fa8a0c893e2ddc691e/src/base.rs#L40

• java-multibase doesn't implement it: https://github.com/multiformats/java-multibase/blob/0f02fa1753bc0418c072ccf2d11447545ed5f3de/src/main/java/io/ipfs/multibase/Multibase.java#L38-L49

• py-multibase doesn't implement it: https://github.com/multiformats/py-multibase/blob/8f435762b50a17f921c13b59eb0c7b9c52afc879/multibase/multibase.py#L9-L24

• haskell-multibase doesn't implement it: https://github.com/multiformats/haskell-multibase/blob/1d46c69131587770436900b4b7e27533e09bb3be/src/Multibase.hs#L30-L42

• scala-multibase doesn't implement it: https://github.com/fluency03/scala-multibase/blob/master/src/main/scala/com/github/fluency03/multibase/Multibase.scala#L9

• ex-multibase does implement it: https://github.com/nocursor/ex-multibase/blob/beddfe5fd0d24921564271483d71e7ae0798d697/lib/multibase.ex#L159-L162 ( https://github.com/nocursor/base1 )

Out of all multibase implementation only one has Base1

[Stebalien]

Approved in #57.

[Stebalien]

@fabianhjr thanks for putting together that list!

[fabianhjr]

Be welcome, thanks for removing Base1 from the spec. I am more at ease now. xD