-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename namespaces and remove "ipfs" alias for "p2p" #283
Conversation
Previously, we called these foo-ns. Now we just call them foo (the fact that they're "namespaces" is implicit. This way, the path component always matches the multicodec name (for both multiaddr and other path types).
Nice. |
ipld, namespace, 0xe2, draft, IPLD path | ||
ipfs, namespace, 0xe3, draft, IPFS path | ||
swarm, namespace, 0xe4, draft, Swarm path | ||
ipns, namespace, 0xe5, draft, IPNS path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @makoto – fysa in case this impacts ENS (i know you use ipfs-ns
and ipns-ns
codes for identifying /ipfs/
and /ipns/
content paths, but not sure if you ever rely on their string labels)
I would like to use human-readable codec names in an API but this makes me think twice, is it incorrect to consider these names as stable? If these are considered unstable, then we should make this clear in the docs and probably remove the recommendation to parse these names or use them programmatically. |
@guseggert mostly we try to keep them stable, but there are occasions like this when they get changed but I think in this case these names are not as likely to be used as they were anyway so the impact is considered fairly low. We're not about to go changing "dag-pb" or other commonly used names, however, even in cases where there's name-regret. We also have this "draft" thing now, and these are drafts so that lessens the burden. Perhaps we don't document it but maybe there's an implicit "we won't touch this if it's 'permanent'". |
Previously, we called these foo-ns. Now we just call them foo (the fact that they're "namespaces" is implicit.
This way, the path component always matches the multicodec name (for both multiaddr and other path types).