Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'host-header' to table.csv #296

Closed
wants to merge 1 commit into from
Closed

Add 'host-header' to table.csv #296

wants to merge 1 commit into from

Conversation

thibmeu
Copy link

@thibmeu thibmeu commented Oct 13, 2022

Host header as defined by HTTP RFC 2616 § 14.23.

Relates to multiformats/multiaddr#144 and libp2p/go-libp2p#1829

cc @MarcoPolo

@rvagg
Copy link
Member

rvagg commented Oct 14, 2022

So this is basically like sni in a multiaddr?
Seams reasonable to me. The name is a little verbose but I suppose host isn't really a good option either!
Will leave it up to the multiaddr/libp2p folks to approve and merge. @mxinden @marten-seemann.

@rvagg
Copy link
Member

rvagg commented Oct 14, 2022

@thibmeu it's failing validation (you can run validate.py for yourself to check), needs a comma after host-header.

@MarcoPolo
Copy link
Contributor

So this is basically like sni in a multiaddr?
Seams reasonable to me. The name is a little verbose but I suppose host isn't really a good option either!

Yup. sni is just for TLS. This will set the host header for http.

@thibmeu
Copy link
Author

thibmeu commented Oct 14, 2022

@thibmeu it's failing validation (you can run validate.py for yourself to check), needs a comma after host-header.

fixed

Host header as defined by HTTP [RFC 2616 § 14.23](https://www.rfc-editor.org/rfc/rfc2616#section-14.23).
@BigLep
Copy link

BigLep commented Nov 22, 2022

@MarcoPolo or @marten-seemann : can you please review/merge? (this came up in IPLD triage)

@MarcoPolo
Copy link
Contributor

Do folks need this? We didn't end up needing this because SNI and Host is so tightly linked we chose to use only SNI for now. But this should be fine to merge if we need it

@MarcoPolo
Copy link
Contributor

Closing this for now. Feel free to reopen if needed.

@MarcoPolo MarcoPolo closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants