Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http-path #352

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add http-path #352

merged 1 commit into from
Jun 5, 2024

Conversation

MarcoPolo
Copy link
Contributor

The multicodec corollary to multiformats/multiaddr#164

closes #324

@MarcoPolo MarcoPolo requested review from rvagg and vmx as code owners June 5, 2024 01:39
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice to get this formalised

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really followed any discussion about it, but I also don't have any objections.

@rvagg
Copy link
Member

rvagg commented Jun 5, 2024

History here is that ipni introduced this originally as httpath and there's been a multi-year discussion about getting it formalised; I think ipni still uses httpath so may have to do some bridging to http-path.

We probably should ping @willscott and @gammazero about this I guess. It'll close the one I opened but was objected to @ #324

@MarcoPolo MarcoPolo merged commit 8fc4918 into master Jun 5, 2024
2 checks passed
@MarcoPolo MarcoPolo deleted the http-path branch June 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants