fix: update ls spec to match implementation(s) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to multiformats/go-multistream#41 and documenting the change to fix it here multiformats/go-multistream#43.
Stebalien
approved these changes
Sep 4, 2019
| < <varint-length><protocol><newline> | ||
| # ... | ||
| < <varint-length><protocol><newline> | ||
| > <varint-ls-length>ls\n |
There was a problem hiding this comment.
Note: ls isn't a proper protocol and probably shouldn't be listed.
There was a problem hiding this comment.
In the response? Yeah that makes sense. Shall I add that note?
There was a problem hiding this comment.
I'd just remove it. We shouldn't list it as a protocol.
There was a problem hiding this comment.
...but this is the example where the local node sends ls and the remote then responds.
There was a problem hiding this comment.
Someday I'll learn how to read.
jacobheun
added a commit
to jacobheun/it-multistream-select
that referenced
this pull request
Sep 9, 2019
multistream spec multiformats/multistream-select#19
alanshaw
pushed a commit
to alanshaw/it-multistream-select
that referenced
this pull request
Sep 10, 2019
Multistream spec: multiformats/multistream-select#19 fixes #4
jacobheun
added a commit
to multiformats/js-multistream-select
that referenced
this pull request
Sep 20, 2019
Multistream spec: multiformats/multistream-select#19 fixes #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to multiformats/go-multistream#41 and documenting the change to fix it here multiformats/go-multistream#43.