Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

Commit

Permalink
mptcp: Avoid over-scheduling on a subflow
Browse files Browse the repository at this point in the history
When the scheduled data exactly fits the available space, we should no
more add more data to the subflow. Thus, the if-condition must be >=
space.

Reported-by: Anh Vu Vu <vuanh.vu@ikt.uni-hannover.de>
Fixes: Zero-day bug
Signed-off-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
(cherry picked from commit ec365b3)
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
(cherry picked from commit 7b3db0c)
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
  • Loading branch information
cpaasch authored and matttbe committed May 15, 2020
1 parent 830a817 commit c83abf4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mptcp/mptcp_sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ static bool mptcp_is_temp_unavailable(struct sock *sk,
*/
space = (tp->snd_cwnd - in_flight) * tp->mss_cache;

if (tp->write_seq - tp->snd_nxt > space)
if (tp->write_seq - tp->snd_nxt >= space)
return true;

if (zero_wnd_test && !before(tp->write_seq, tcp_wnd_end(tp)))
Expand Down

0 comments on commit c83abf4

Please sign in to comment.