Add new world special property (vehicle sun glare effect) #2495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks you for the PR! |
|
@TheNormalnij allright, should cool now |
TheNormalnij
reviewed
Jan 4, 2022
TheNormalnij
reviewed
Jan 7, 2022
Client/game_sa/CGameSA.cpp
Outdated
| @@ -33,17 +33,43 @@ float* CGameSA::VAR_TimeStep; | |||
| unsigned long* CGameSA::VAR_Framelimiter; | |||
|
|
|||
| unsigned int OBJECTDYNAMICINFO_MAX = *(uint32_t*)0x59FB4C != 0x90909090 ? *(uint32_t*)0x59FB4C : 160; // default: 160 | |||
| static int m_iVehicleSunGlare; | |||
There was a problem hiding this comment.
Can bool be used?
I've tried that before, but it seems will resulting crashing on the client.
There was a problem hiding this comment.
BOOL is bool type with int size. Can be used here
There was a problem hiding this comment.
BOOLis bool type with int size. Can be used here
yeah, done! it's works
There was a problem hiding this comment.
m_iVehicleSunGlare -> m_bVehicleSunGlare also
There was a problem hiding this comment.
m_iVehicleSunGlare -> m_bVehicleSunGlare also
Roger that
TheNormalnij
approved these changes
Jan 12, 2022
|
Marge time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR adds the vehicle sun glare effect to the
setWorldSpecialPropertyEnabled,isWorldSpecialPropertyEnabled. The effect is already presented in the SA engine and it's a leftover feature from VC, so it will add some classic aesthetic to the game.Summary:
disabledby default, keeping consistent to the original SA graphical favor.vehiclesunglareis added into the world function, you can set it on or off like other world properties. this includessetWorldSpecialPropertyEnabled,isWorldSpecialPropertyEnabledplanes, maybe due to they are not present in VC and it is no need for R* to update them, but most vehicles should work fine (maybe we need more investigation to find out).Code Example:
setWorldSpecialPropertyEnabled("vehiclesunglare",true)setWorldSpecialPropertyEnabled("vehiclesunglare",false)Test Resource
glare.zip
command
/glareonoroffto switch this effect.