Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lunasvg from 2.2.0 to 2.3.1 #2584

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Update lunasvg from 2.2.0 to 2.3.1 #2584

merged 1 commit into from
Apr 2, 2022

Conversation

patrikjuvonen
Copy link
Contributor

Summary

  • Update lunasvg from 2.2.0 to 2.3.1
  • Fixes and tweaks
  • Versions: 2.3.0, 2.3.1

Validation

To help validate the integrity of the update I have created the following bash script that diffs between my PR branch and the official release provided from the GitHub releases page.

#!/bin/bash

LUNASVG_UPDATE_VERSION=2.3.1
LUNASVG_PATH_NAME=lunasvg-$LUNASVG_UPDATE_VERSION

GIT_REPO_BRANCH=vendor/lunasvg-$LUNASVG_UPDATE_VERSION
GIT_REPO_URL=https://github.com/patrikjuvonen/mtasa-blue.git
GIT_REPO_LUNASVG_PATH=vendor/lunasvg/

echo 1. Download and extract $LUNASVG_PATH_NAME...
curl -L https://github.com/sammycage/lunasvg/archive/refs/tags/v2.3.1.tar.gz | tar -xz

echo 2. Fetch and checkout the vendor update branch $GIT_REPO_BRANCH from $GIT_REPO_URL...
git fetch $GIT_REPO_URL $GIT_REPO_BRANCH:$GIT_REPO_BRANCH
git checkout $GIT_REPO_BRANCH

echo 3. Start checking integrity...
diff -r --strip-trailing-cr $GIT_REPO_LUNASVG_PATH $LUNASVG_PATH_NAME

echo 4. Completed.
exec $SHELL

Past updates in MTA

Date From To Link
September 2021 - 2.2.0 (current) #2380

Copy of changelogs

Version 2.3.0

Version 2.3.1

@patrikjuvonen patrikjuvonen added enhancement New feature or request upstream Related to vendor library labels Mar 31, 2022
@patrikjuvonen patrikjuvonen added this to the Next Release (1.6.0) milestone Mar 31, 2022
@Lpsd
Copy link
Member

Lpsd commented Apr 1, 2022

I believe there's been a mixup somehow - it seems we were already on 2.3.0 (see diff, no removal of document.h since lunasvg.h already exists).

That does make sense as I upgraded to the latest version of lunasvg right before we merged the feature.

Edit: although, I do see the removal of a document.h #include (which doesn't make sense since document.h doesn't even exist and hasn't been removed in that diff?) - as well as the version in README.md being 2.2.0, I think those were overlooked on the vendor's side

this shouldn't actually cause an issue with this upgrade, just thought I'd point it out.

@patrikjuvonen patrikjuvonen merged commit 3635e33 into multitheftauto:master Apr 2, 2022
@patrikjuvonen patrikjuvonen deleted the vendor/lunasvg-2.3.1 branch April 2, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upstream Related to vendor library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants