Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the send button issue in the form #67 #75

Closed
wants to merge 3 commits into from

Conversation

tarunkumar2005
Copy link
Contributor

Description

I have fixed the form layout and send button and it is looking more good now as you can see in the image :-

image

Related Issue

Fixes #67

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 3cefa7b
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/670b5039eb500e0008c346b0
😎 Deploy Preview https://deploy-preview-75--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tarunkumar2005
Copy link
Contributor Author

@multiverseweb Can you review and merge it soon its been so many days since it is open

@tarunkumar2005
Copy link
Contributor Author

@jency1 Can you review this PR and ask the admin to merge it

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tarunkumar2005, I apologize for the delay. The form looks fine in desktop view but there are many issues in the mobile view.
image

I think you missed something in the css file.

@tarunkumar2005
Copy link
Contributor Author

tarunkumar2005 commented Oct 13, 2024

@multiverseweb Now check there was issue in the style.css file there one person didn't comented the word responsive properly and that was breaking the code and so the responsiveness was not there, it is fixed now you can check.

@tarunkumar2005
Copy link
Contributor Author

@multiverseweb Can you check the PR now i have fixed the issues now.

@tarunkumar2005
Copy link
Contributor Author

@multiverseweb @jency1 Can you check the PR and merge it its been open for too long (reminder)

@MastanSayyad
Copy link
Collaborator

@multiverseweb Review this PR if it has done the requested changes and @tarunkumar2005 resolve the conflicts

@multiverseweb
Copy link
Owner

Hey @tarunkumar2005, sorry for delay in code review, was totally packed up.
This is how the current form looks in mobile view:
image

And this is the form in your PR:
image

Here are the issues with this PR:

  • The font-style of the place holder in message field is different as compare to the other two fields.
  • The font color of Let Me Know Your Thoughts has been changed, which makes it disappear in light mode.
  • The margin between fields has been increased, which makes the form look vertically elongated.

The issue #67 only required aligning the send button, which certainly has been solved in you PR, but newer issues have been introduced.
The button alignment has already been fixed in some PR, as you can see here. Therefore, I'm closing the issue.
Let me know if you have further doubts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing the send button issue in the form
3 participants