Mx 14997 overwrite config structs #5851
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #5851 +/- ##
=================================================
+ Coverage 80.32% 80.39% +0.07%
=================================================
Files 710 710
Lines 94069 94222 +153
=================================================
+ Hits 75563 75753 +190
+ Misses 13222 13189 -33
+ Partials 5284 5280 -4 ☔ View full report in Codecov by Sentry. |
| { File = "config.toml", Path = "TestConfigStruct.ConfigStruct.Description", Value = { Nr = 222 } }, | ||
| { File = "config.toml", Path = "TestConfigStruct.ConfigStruct.Description", Value = { Number = "11" } }, | ||
| { File = "config.toml", Path = "TestConfigNestedStruct.ConfigNestedStruct", Value = { Text = "Overwritten text", Message = { Public = false, MessageDescription = [{ Text = "Overwritten Text1" }] } } }, | ||
| { File = "config.toml", Path = "TestConfigNestedStruct.ConfigNestedStruct.Message.MessageDescription", Value = [{ Text = "Overwritten Text1" }, { Text = "Overwritten Text2" }] }, |
There was a problem hiding this comment.
maybe add an example like this on the original prefs.toml?
There was a problem hiding this comment.
This is already presented in prefs.toml but it's commented out.
This will be used later (we need this for some override in sovereign)
There was a problem hiding this comment.
This feature is useful even if the sovereign is not finalized. A good example here is to override in prefs.toml file some settings regarding the HostDriverConfig from the external.toml file. Can we add a comment that makes a good example of how to override the Enabled & URL from that slice from external.toml file?
axenteoctavian
dismissed
iulianpascalau’s stale review
The base branch was changed.
There was a problem hiding this comment.
Normal allin test: master-06f147d698 -> MX-14997-overwrite-config--4867e64b04
--- Specific errors ---
block hash does not match 5407
wrong nonce in block 2131
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 399
Nr. of new ERRORS: 0
Nr. of new WARNS: 2
Nr. of PANICS: 0
/------/
--- ERRORS ---
/------/
--- WARNINGS ---
/------/
Reasoning behind the pull request
Proposed changes
stringtointerface{}sliceandstructcasesint, but the actual config objects can beint8,uint8,int16and so onTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?