Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go mod #6425

Merged
merged 3 commits into from
Sep 2, 2024
Merged

update go mod #6425

merged 3 commits into from
Sep 2, 2024

Conversation

BeniaminDrasovean
Copy link
Contributor

@BeniaminDrasovean BeniaminDrasovean commented Aug 29, 2024

Reasoning behind the pull request

  • Fix a backwards incompatibility related to dynamic roles

Proposed changes

  • Use ESDTRoleNFTUpdateAttributes and ESDTRoleNFTAddURI as dynamic roles only after the activation of the DynamicNFT flag

Testing procedure

  • Normal testing and import-db

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: b4b7a2ad38cc62cb385d04fc548ecbcc5aa9ddc0
  • Current Branch: dynamic-roles-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 29082024-193724
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@BeniaminDrasovean BeniaminDrasovean self-assigned this Aug 29, 2024
ssd04
ssd04 previously approved these changes Aug 30, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: dd9dcaf48436b5efd76a37b720eb6f8c96742029
  • Current Branch: dynamic-roles-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 30082024-103926
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.13-patch2-41962f78a1 -> dynamic-roles-fix-dd9dcaf484

--- Specific errors ---

block hash does not match 476
wrong nonce in block 313
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 322
Nr. of new ERRORS: 0
Nr. of new WARNS: 22
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

Copy link

github-actions bot commented Sep 2, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 305c5c19f00fdf6f2fa592537c39df0f5003f9a0
  • Current Branch: dynamic-roles-fix
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 02092024-131349
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@BeniaminDrasovean BeniaminDrasovean merged commit b44fe4a into rc/v1.7.next1 Sep 2, 2024
9 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the dynamic-roles-fix branch September 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants