Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go mod and refactor some tests #6458

Merged

Conversation

BeniaminDrasovean
Copy link
Contributor

Reasoning behind the pull request

  • The Reserved field of the ESDTMetaData was overwritten with 0 in some cases

Proposed changes

  • Do not overwrite the Reserved field with 0 if the metaData was already updated.
  • Refactor some integration tests to also check the Reserved field
  • Keep metaData on zero liquidity if DynamicSFT or DynamicMetaESDT

Testing procedure

  • Normal testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

sasurobert
sasurobert previously approved these changes Sep 12, 2024
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 3ec3288f3c6f9c257309a201897842ed0514dc1d
  • Current Branch: keep-metadata-on-zero-liquidity-fixes
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 12092024-122415
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 4e58b182b7d88dd55e736ea058a944974e4472fc
  • Current Branch: keep-metadata-on-zero-liquidity-fixes
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 12092024-134644
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link
Collaborator

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: 1.7.13-patch2-41962f78a1 -> keep-metadata-on-zero-liqu-4e58b182b7

--- Specific errors ---

block hash does not match 1823
wrong nonce in block 844
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 266
Nr. of new ERRORS: 0
Nr. of new WARNS: 5
Nr. of PANICS: 0

/------/

--- ERRORS ---

/------/

--- WARNINGS ---

/------/

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 8569fe92cddb6ad82878376c865c39aac8ef40b3
  • Current Branch: keep-metadata-on-zero-liquidity-fixes
  • mx-chain-go Target Branch: rc/v1.7.next1
  • mx-chain-simulator-go Target Branch: rc/v1.7.next1
  • mx-chain-testing-suite Target Branch: rc/v1.7.next1

🚀 Environment Variables:

  • TIMESTAMP: 13092024-073954
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@BeniaminDrasovean BeniaminDrasovean merged commit e80c725 into rc/v1.7.next1 Sep 13, 2024
9 checks passed
@BeniaminDrasovean BeniaminDrasovean deleted the keep-metadata-on-zero-liquidity-fixes branch September 13, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants