Implemented Token Management Transactions Outcome Parser #381
Conversation
| @@ -106,6 +103,9 @@ export interface IBurnQuantityOutcome { | |||
| burntQuantity: string; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated Use {@link TokenManagementTransactionsOutcomeParser} | |||
There was a problem hiding this comment.
Indeed, we are deprecating this 👍
CC: @arhtudormorar
| @@ -0,0 +1,55 @@ | |||
| export class TransactionEvent { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I think we can apply this pattern on TransactionNext, as well (Partial & Object.assign).
| this.ensureNoError(transactionOutcome.transactionLogs.events); | ||
|
|
||
| const event = this.findSingleEventByIdentifier(transactionOutcome, "issue"); | ||
| const identifer = this.extractTokenIdentifier(event); |
There was a problem hiding this comment.
Typo - here and below.
|
|
||
| let roles: string[] = []; | ||
| for (const role of encodedRoles) { | ||
| const decodedRole = Buffer.from(role, "base64"); |
There was a problem hiding this comment.
Decoding from base64 is used in several places - perhaps extract it to decodeTopicAsString() or something similar? Optional.
| parseNftCreate(transactionOutcome: TransactionOutcome): { | ||
| tokenIdentifier: string; | ||
| nonce: bigint; | ||
| initialQuantity: bigint; |
| }); | ||
|
|
||
| it("should test parse issue fungible", () => { | ||
| const identifer = "ZZZ-9ee87d"; |
| }); | ||
|
|
||
| const logs = new TransactionLogs({ events: [event] }); | ||
| const scResult = new SmartContractResult({}); |
There was a problem hiding this comment.
Does the test work if we don't pass smartContractResults? If so, let's simplify it (better for advertising the parsers).
There was a problem hiding this comment.
It does work. Will remove empty objects.
| events: [event], | ||
| }); | ||
|
|
||
| const scResult = new SmartContractResult({}); |
There was a problem hiding this comment.
Also here (and below), if possible to not pass scResult (if not needed), let's do that. On the other hand, it's worth to emphasize that the parser is able to gather logs from the contract results, as well - and you have an example for that below 👍
Implemented the transaction parser for Token Management Transactions. This is meant to be used together with the
TokenManagementTransactionsFactory.