SmartContractTransactionsOutcomeParser - parseDeploy() #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
Mar 28, 2024
| @@ -117,7 +117,7 @@ export class TransactionsConverter { | |||
| // Before Sirius, there was no "additionalData" field on transaction logs. | |||
| // After Sirius, the "additionalData" field includes the payload of the legacy "data" field, as well (as its first element): | |||
| // https://github.com/multiversx/mx-chain-go/blob/v1.6.18/process/transactionLog/process.go#L159 | |||
| const legacyData = eventOnNetwork.dataPayload?.valueOf() || Buffer.from([]); | |||
| const legacyData = eventOnNetwork.dataPayload?.valueOf() || Buffer.from(eventOnNetwork.data || ""); | |||
There was a problem hiding this comment.
Better handling of legacy data.
andreibancioiu
commented
Mar 28, 2024
| @@ -32,15 +32,15 @@ export class Address { | |||
| /** | |||
| * Creates an address object, given a raw string (whether a hex pubkey or a Bech32 address), a sequence of bytes, or another Address object. | |||
| */ | |||
| public constructor(value: Address | Buffer | string) { | |||
| public constructor(value: Address | Buffer | Uint8Array | string) { | |||
There was a problem hiding this comment.
Small preparation for future updates.
andreibancioiu
commented
Mar 28, 2024
| } | ||
|
|
||
| return events; | ||
| return findEventsByPredicate(transactionOutcome, (event) => event.identifier == identifier); |
There was a problem hiding this comment.
Arbitrary constraint about any / no found events was dropped (not useful).
popenta
approved these changes
Mar 28, 2024
bogdan-rosianu
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: multiversx/mx-sdk-specs#60.