-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feat/next into main (v13.1.0) #445
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into feat/next
Added missing role(ESDTTransferRole) on fungible token
Changed ESDTTransferRole to be mandatory
Implemented Account Transactions Factory
In "createTransactionForUpgrade()", use the "upgrade" definition (if available)
Formatting for release v13.1.0
Formatting for release v13.1.0 part II
Tests formatting for release v13.1.0
Analyze serialization of variadic arguments (v12 vs v13)
iulianpascalau
approved these changes
Apr 18, 2024
radumojic
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ ❗ In
TokenManagementTransactionsFactory
, added missing roleESDTTransferRole
on fungible token (by @popenta in #437). Made in mandatory (by @popenta in #440). This shouldn't be considered a breaking change. It's a minor (trivial) fixing change.🔵 Implemented
AccountTransactionsFactory
(by @popenta in #439).🔵 Improved
SmartContractTransactionsFactory
: increateTransactionForUpgrade()
, use theupgrade
definition, if available (by @andreibancioiu in #438).❗ Analyze serialization of variadic arguments (v12 vs v13) (by @andreibancioiu in #441). Documented a previously unforeseen minor breaking change (when migrating from v12 to v13).
✍️ Formatting part I (by @popenta in #442).
✍️ Formatting part II (by @popenta in #443).
✍️ Formatting part III (by @popenta in #444).