Add explicit enums implementation #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielailie
commented
Nov 12, 2024
danielailie
commented
- Fix handling of explicit-enums #519
|
|
||
| const typedValues = NativeSerializer.nativeToTypedValues([p1], endpoint); | ||
|
|
||
| console.log(typedValues[0].valueOf()); |
|
|
||
| // Simple enum by name | ||
| const p1 = "completed"; | ||
| // Enum with a single field |
There was a problem hiding this comment.
Comment / code alignment.
Comment on lines
+67
to
+70
| } else if (typeDefinition.type == "enum") { | ||
| customTypes.push(EnumType.fromJSON({ name: customTypeName, variants: typeDefinition.variants })); | ||
| } else if (typeDefinition.type == "explicit-enum") { | ||
| customTypes.push( |
| import { StringBinaryCodec } from "./string"; | ||
|
|
||
| export class ExplicitEnumBinaryCodec { | ||
| private readonly stringCodec: StringBinaryCodec; |
andreibancioiu
approved these changes
Nov 12, 2024
popenta
approved these changes
Nov 12, 2024
| @@ -107,6 +112,12 @@ export class AbiRegistry { | |||
| return <EnumType>result!; | |||
| } | |||
|
|
|||
| getExplicitEnum(name: string): ExplicitEnumType { | |||
| const result = this.customTypes.find((e) => e.getName() == name && e.hasExactClass(ExplicitEnumType.ClassName)); | |||
There was a problem hiding this comment.
Perhaps it does not help in this case, but I think it would be a good practice to use === wherever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.