t.geoserver.publish: limit color options to those GeoServer can handle #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Dec 12, 2022
| @@ -44,6 +44,7 @@ | |||
| # % type: string | |||
| # % required: no | |||
| # % multiple: no | |||
| # % options: bcyr,bgyr,blues,byg,byr,default,elevation,evi,forest_cover,grass,greens,grey,gyr,ndvi,ndwi,reds,ryb,ryg | |||
| # % label: Name of color table for layer styling | |||
| # %end | |||
There was a problem hiding this comment.
Please consider to use the related macro
# %option G_OPT_M_COLR
see e.g.:
There was a problem hiding this comment.
Thanks! I add the default- answer, plus I limit the allowed options. Is this valid when using the macro? (probably yes as it only overwrites parts of the macro?)
There was a problem hiding this comment.
After testing, I would refrain from using # %option G_OPT_M_COLR, as together with using options it yields unclear Warnings when calling the module:
GRASS utm32n_wgs84/openeo_example_strds:~ > t.geoserver.publish input=S2_STRDS_B04_10m mosaic_layername=bla color=default
WARNUNG: Bug in UI description. Option 'aspect' in <color> does not exist
WARNUNG: Bug in UI description. Option 'aspectcolr' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'celsius' in <color> does not exist
WARNUNG: Bug in UI description. Option 'corine' in <color> does not exist
WARNUNG: Bug in UI description. Option 'curvature' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'differences' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'etopo2' in <color> does not exist
WARNUNG: Bug in UI description. Option 'fahrenheit' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'gdd' in <color> does not exist
WARNUNG: Bug in UI description. Option 'grey.eq' in <color> does not exist
WARNUNG: Bug in UI description. Option 'grey.log' in <color> does not exist
WARNUNG: Bug in UI description. Option 'grey1.0' in <color> does not exist
WARNUNG: Bug in UI description. Option 'grey255' in <color> does not exist
WARNUNG: Bug in UI description. Option 'haxby' in <color> does not exist
WARNUNG: Bug in UI description. Option 'inferno' in <color> does not exist
WARNUNG: Bug in UI description. Option 'kelvin' in <color> does not exist
WARNUNG: Bug in UI description. Option 'magma' in <color> does not exist
WARNUNG: Bug in UI description. Option 'nlcd' in <color> does not exist
WARNUNG: Bug in UI description. Option 'oranges' in <color> does not exist
WARNUNG: Bug in UI description. Option 'plasma' in <color> does not exist
WARNUNG: Bug in UI description. Option 'population' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'population_dens' in <color> does
not exist
WARNUNG: Bug in UI description. Option 'precipitation' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'precipitation_daily' in <color>
does not exist
WARNUNG: Bug in UI description. Option 'precipitation_monthly' in <color>
does not exist
WARNUNG: Bug in UI description. Option 'rainbow' in <color> does not exist
WARNUNG: Bug in UI description. Option 'ramp' in <color> does not exist
WARNUNG: Bug in UI description. Option 'random' in <color> does not exist
WARNUNG: Bug in UI description. Option 'roygbiv' in <color> does not exist
WARNUNG: Bug in UI description. Option 'rstcurv' in <color> does not exist
WARNUNG: Bug in UI description. Option 'sepia' in <color> does not exist
WARNUNG: Bug in UI description. Option 'slope' in <color> does not exist
WARNUNG: Bug in UI description. Option 'soilmoisture' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'srtm' in <color> does not exist
WARNUNG: Bug in UI description. Option 'srtm_plus' in <color> does not
exist
WARNUNG: Bug in UI description. Option 'terrain' in <color> does not exist
WARNUNG: Bug in UI description. Option 'viridis' in <color> does not exist
WARNUNG: Bug in UI description. Option 'water' in <color> does not exist
WARNUNG: Bug in UI description. Option 'wave' in <color> does not exist
There was a problem hiding this comment.
Aren't the color names listed as ... does not exist those color names which you removed from the full list by defining a subset?
Seems the parser isn't prepared for that (yet).
There was a problem hiding this comment.
yes indeed. I meant they are "unclear" such that a user might not know what to do with this warning at all.
There was a problem hiding this comment.
I have reported it upstream in OSGeo/grass#2708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts
t.geoserver.publishto limit color options to those that GeoServer can handle. For color scales likemagma, viridis, etc. the GRASS color definition is so long that the output SLD is not accepted as GeoServer style. It is still possible to not provide a color (either by not filling the color parameter or choosing thedefaultvalue), in which case the result will be in grey values.This has the nice side effect that a drop-down menu with the available options is shown if the module is called via the OpenEO WebEditor