Rename note Hooks to Flags, to match SMuFL terms (master)

and to differentiate from line hooks
musescore · Oct 11, 2020 · 2d0d23c · 2d0d23c
1 parent 6540df7
commit 2d0d23c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/libmscore/hook.cpp b/libmscore/hook.cpp
@@ -79,7 +79,7 @@ void Hook::setHookType(int i)
     case -8:   setSym(SymId::flag1024thDown);
         break;
     default:
-        qDebug("no hook for subtype %d", i);
+        qDebug("no hook/flag for subtype %d", i);
         break;
     }
 }

diff --git a/libmscore/scoreElement.cpp b/libmscore/scoreElement.cpp
@@ -62,7 +62,7 @@ static const ElementName elementNames[] = {
     { ElementType::CHORDLINE,            "ChordLine",            QT_TRANSLATE_NOOP("elementName", "Chord Line") },
     { ElementType::DYNAMIC,              "Dynamic",              QT_TRANSLATE_NOOP("elementName", "Dynamic") },
     { ElementType::BEAM,                 "Beam",                 QT_TRANSLATE_NOOP("elementName", "Beam") },
-    { ElementType::HOOK,                 "Hook",                 QT_TRANSLATE_NOOP("elementName", "Hook") },
+    { ElementType::HOOK,                 "Hook",                 QT_TRANSLATE_NOOP("elementName", "Flag") }, // internally called "Hook", but "Flag" in SMuFL, so here externally too
     { ElementType::LYRICS,               "Lyrics",               QT_TRANSLATE_NOOP("elementName", "Lyrics") },
     { ElementType::FIGURED_BASS,         "FiguredBass",          QT_TRANSLATE_NOOP("elementName", "Figured Bass") },
     { ElementType::MARKER,               "Marker",               QT_TRANSLATE_NOOP("elementName", "Marker") },

diff --git a/mscore/debugger/chord.ui b/mscore/debugger/chord.ui
@@ -56,7 +56,7 @@
          <string notr="true"/>
         </property>
         <property name="text">
-         <string notr="true">Hook</string>
+         <string notr="true">Flag</string>
         </property>
        </widget>
       </item>

diff --git a/mu4/inspector/models/notation/notes/hooks/hooksettingsmodel.cpp b/mu4/inspector/models/notation/notes/hooks/hooksettingsmodel.cpp
@@ -6,7 +6,7 @@ HookSettingsModel::HookSettingsModel(QObject* parent, IElementRepositoryService*
     : AbstractInspectorModel(parent, repository)
 {
     setModelType(TYPE_HOOK);
-    setTitle(tr("Hook"));
+    setTitle(tr("Flag")); // internally called "Hook", but "Flag" in SMuFL, so here externally too
 
     createProperties();
 }