Fix #317425: Corruption/crash after repeating a 256th note or smaller.

Resolves: https://musescore.org/en/node/317425. In the MIME data for a StaffList, the starting tick and tick length are encoded as integers, which is not sufficient when dealing with durations shorter than 1/128th. But there is really no reason for this, since ticks are stored internally as Fractions, and Fractions can be converted to and from strings without any loss in precision.
musescore · Feb 12, 2021 · 476a7dc · 476a7dc
1 parent 84f6aa7
commit 476a7dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libmscore/paste.cpp b/libmscore/paste.cpp
@@ -106,8 +106,8 @@ bool Score::pasteStaff(XmlReader& e, Segment* dst, int dstStaff, Fraction scale)
                         break;
                         }
                   }
-            Fraction tickStart = Fraction::fromTicks(e.intAttribute("tick", 0));
-                tickLen       =  Fraction::fromTicks(e.intAttribute("len", 0));
+            Fraction tickStart = Fraction::fromString(e.attribute("tick", "0"));
+                tickLen       =  Fraction::fromString(e.attribute("len", "0"));
             Fraction oTickLen =  tickLen;
                 tickLen       *= scale;
             int staffStart    = e.intAttribute("staff", 0);

diff --git a/libmscore/select.cpp b/libmscore/select.cpp
@@ -813,10 +813,10 @@ QByteArray Selection::staffMimeData() const
       Fraction ticks  = tickEnd() - tickStart();
       int staves = staffEnd() - staffStart();
       if (!MScore::testMode) {
-            xml.stag(QString("StaffList version=\"" MSC_VERSION "\" tick=\"%1\" len=\"%2\" staff=\"%3\" staves=\"%4\"").arg(tickStart().ticks()).arg(ticks.ticks()).arg(staffStart()).arg(staves));
+            xml.stag(QString("StaffList version=\"" MSC_VERSION "\" tick=\"%1\" len=\"%2\" staff=\"%3\" staves=\"%4\"").arg(tickStart().toString()).arg(ticks.toString()).arg(staffStart()).arg(staves));
             }
       else {
-            xml.stag(QString("StaffList version=\"2.00\" tick=\"%1\" len=\"%2\" staff=\"%3\" staves=\"%4\"").arg(tickStart().ticks()).arg(ticks.ticks()).arg(staffStart()).arg(staves));
+            xml.stag(QString("StaffList version=\"2.00\" tick=\"%1\" len=\"%2\" staff=\"%3\" staves=\"%4\"").arg(tickStart().toString()).arg(ticks.toString()).arg(staffStart()).arg(staves));
             }
       Segment* seg1 = _startSegment;
       Segment* seg2 = _endSegment;