-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4] Fix #306189: Extend Tremolo palette #10000
Conversation
abb0266
to
84b9b6b
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
84b9b6b
to
2c861da
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
2c861da
to
c1c8032
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
c1c8032
to
48360d9
Compare
48360d9
to
45bb8f9
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
Of course, if it is really desired to have a "below the staff" version, you can offset the symbol by |
If the SMuFL spec implies they should only go above notes, we should probably respect that. That said, even symbols which should always go above sometimes need to go below (when applying to a second voice with stems down), though generally these are then mirrored vertically (which would work fine here). If the aim is to use these symbols as stand-ins for repeated staccatos, I'd prefer to avoid a hack just to make that work - because if we wish to do that, we should instead implement a better solution that a) uses the primary staccato symbol and b) can work with other articulation marks as well. |
Well, the original requests for these shows them under the notes. |
With respect to MusicXML, I can't find anything in the current spec related to tremolo division dots. This may not be supported yet. Also, the SMuFL description "Divide measured tremolo by [2-4.6]" suggest the semantics differ from staccato. Exporting as staccato could be incorrect (even though it would be visually similar). |
45bb8f9
to
6080e22
Compare
OK, thanks, I've removed them from MusicXML export. |
6080e22
to
ee93ede
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
e689ae4
to
837538c
Compare
837538c
to
bb9eb99
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
bb9eb99
to
01f42a7
Compare
01f42a7
to
d153a54
Compare
Good Job on getting all the x000 to 10000 @Jojo-Schmitz |
b8fdecc
to
7442134
Compare
to allow for "Divide measured tremolo by [2-4.6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either). Backport of musescore#10000
What is the status of this: #10000 (comment) ? |
No change as far as I can tell, but let's rebase first |
0c503fc
to
b3eeaf5
Compare
to allow for "Divide measured tremolo by [2-4,6]", `tremoloDivisiDots[2-4,6]`, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).
b3eeaf5
to
0e14035
Compare
to allow for "Divide measured tremolo by [2-4.6]",
tremoloDivisiDots[2-4,6]
, implemented as articulations, actually even as staccatos, but (currently) without any playback effect on tremolos (as 'normal' staccatos don't work on those either).Resolves: https://musescore.org/en/node/106081 and https://musescore.org/en/node/306189 as well as a recent discussion in the OpenScore Contributors' Telegram chat and the notation channel on the MuseScore Discord server.
Not sure yet how to deal with MusicXML ex- and import, or whether at all, @lvinken ? For now just the staccato itself is exported in case of those added symbols