"Last system fill threshold" should also apply to section breaks #10577
Conversation
|
Fixes https://musescore.org/en/node/81856 I wonder what that crash in the utests is about |
… breaks Backport of musescore#10577
| @@ -381,8 +381,9 @@ System* LayoutSystem::collectSystem(const LayoutOptions& options, LayoutContext& | |||
| // proportional to the difference between the current length and the target length. | |||
| // After few iterations, the length will converge to the target length. | |||
| qreal newRest = systemWidth - curSysWidth; | |||
| if (ctx.curMeasure == 0 && ((curSysWidth / systemWidth) <= score->styleD(Sid::lastSystemFillLimit))) { | |||
| // We do not stretch last system if curSysWidth is <= lastSystemFillLimit | |||
| if ((ctx.curMeasure == 0 || system->lastMeasure()->sectionBreak()) | |||
There was a problem hiding this comment.
Could use lm->sectionBreak() here. And check whether lm exists first... might fix that crash?
There was a problem hiding this comment.
Actually that check does fix the crash: if ((ctx.curMeasure == 0 || (lm && lm->lastMeasure()->sectionBreak()))
There was a problem hiding this comment.
yup, good catch! thanks
… breaks Backport of musescore#10577
mike-spa
force-pushed
the
lastSystemFillLimit_sectionBreaks
branch
from
d019dca
to
189e873
Compare
… breaks Backport of musescore#10577
… breaks Backport of musescore#10577
… breaks Backport of musescore#10577
This is a tiny fix.
The setting "Last system fill threshold" (from Style -> Page), by which we don't justify the last system if its width is smaller than a given amount, should also apply to section breaks.
For reference, this is what the program does now (and also MU3.6)
but this would be the correct layout
I don't see any obvious downsides to making this the default behaviour. @oktophonie