[MU4] Use std::gcd()
#11560
Merged
[MU4] Use std::gcd()
#11560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and return from creating an invalid tuplet early, this should fix https://musescore.org/en/node/331840, "Creating a 4-or-higher tuplet on a 512th or an 8-or-higher tuplet on a 256th crashes Musescore", it at least prevents the crash. It does not bring up the "Tuplet too short" dialog though, for that see musescore#11561.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 7, 2022
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
Jojo-Schmitz
commented
May 7, 2022
igorkorsukov
approved these changes
May 9, 2022
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
or an 8-or-higher tuplet on a 256th Sort of a backport of musescore#11560 (without the `std::gcd()` part) and musescore#11561.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use C++17's
std::gcd()rather than our own implementation.