[MU4] Switch to using Visual Studio 2022

[Jojo-Schmitz]

Resolves: #12083

[Jojo-Schmitz]

I wonder where to check whether GitHub CI used Visual Studio 2022?

Edit: apparently not:

2022-06-18T12:59:30.8265993Z "Setup VS Environment"
2022-06-18T12:59:31.3065543Z "VS_INSTALL_DIR: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise"
2022-06-18T12:59:31.5739453Z **********************************************************************
2022-06-18T12:59:31.5739804Z ** Visual Studio 2019 Developer Command Prompt v16.11.16
2022-06-18T12:59:31.5744208Z ** Copyright (c) 2021 Microsoft Corporation

Lokking at build/cmake_wrapper.bat

echo "Setup VS Environment"
set VSWHERE="C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe"
for /f "usebackq tokens=*" %%i in (`%VSWHERE% -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath`) do (
    set VS_INSTALL_DIR=%%i
)
echo "VS_INSTALL_DIR: %VS_INSTALL_DIR%"

seems to indicate that there's no VS 2022 found/available on GitHub CI

[cbjeukendrup]

We use the "windows-2019" environment on CI:

MuseScore/.github/workflows/ci_windows_mu4.yml

Line 26 in 5f851d1

runs-on: windows-2019

Which has Visual Studio 2019:
https://github.com/actions/virtual-environments/blob/main/images/win/Windows2019-Readme.md#visual-studio-enterprise-2019

[Jojo-Schmitz]

Thanks, looks better using "windows-2022"

msvc_build.bat doesn't seem to recognize my parallel install of VS 2022, falls trough to using 2019

Edit: got it, wrong order, resp. missing check.

[wizofaus]

Is this going to force all contributors who use MSVC to upgrade to 2022? I agree we should encourage it and enforce say from a certain date, but just merging it and doing so with no warning seems a bit unfair...

[Jojo-Schmitz]

As far as I can tell MSVC 2019 still works with that PR. msvc_build.bat uses VS 2022 if found, if not checks for VS 2019, if not found either uses VS 2017, while build.cmake defaults to VS 2022, but allows overriding with VS 2019. But better test it and report back ;-)
VS 2022 is available and stable since a while, hanging on to a 3 years old version shouldn't be the way forward, really.

[wizofaus]

VS 2017 hasn't worked for a long time! But sure, I'll try it out tomorrow.
Are there any VS-2022-specific features that are likely to be useful in developing MuseScore?

[Jojo-Schmitz]

VS 2017 most likely is a historical leftover in that script, let's remove it (we now do need a C++2017 compiler for master, so indeed VS 2017 will no longer work). Not sure about any VS 2022 specific features we'd benefit from, other than newer compilers.

Found in the web: "One of the main improvements in the new release addresses a recurring complaint about VS 2019—namely, its intense demand on memory.", Others are improved code-completion functionality, more powerful debugging capabilities, improved programming interface, improved accessibility, improved support for the latest build of C++ (C++2020), improved Windows app development (hot reload)