Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opus] cmake - intinsics fixes, only compile SSE source with SSE flags on no… #13794

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

AntonioBL
Copy link
Contributor

…n-windows when target use runtime check. For windows we only use /arch flag when target is presumed to support SSE to avoid AVX function pollution.

Cherry-picked from upstream opus xiph/opus@927de8453c50258

Signed-off-by: Jean-Marc Valin
Signed-off-by: AntonioBL

Resolves: issue 13666

See discussion in xiph/opus#154

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

…n-windows when target use runtime check. For windows we only use /arch flag when target is presumed to support SSE to avoid AVX function pollution.

Cherry-picked from upstream opus xiph/opus@927de8453c50258

Signed-off-by: Jean-Marc Valin
Signed-off-by: AntonioBL
@vpereverzev vpereverzev merged commit 11f5d67 into musescore:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on export as .ogg
3 participants