Fix cross system glissando bug #14890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Dec 2, 2022
This was referenced Dec 18, 2022
|
@RomanPudashkin @vpereverzev - can you let us know if this is safe to merge for 4.0.2 |
correction
mike-spa
force-pushed
the
fixCrossSystemGlissandoBug
branch
from
4f5e09d
to
32d17b7
Compare
|
@RomanPudashkin thank you! I've implemented all your suggestions, let me know if it's good to go 👍 |
RomanPudashkin
approved these changes
Feb 6, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Feb 6, 2023
plus a vtest Backport of musescore#14890
Merged
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
plus a vtest Backport of musescore#14890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15295
A nasty bug with glissandos when start-end notes cross systems (see vtest). Basically, the computation wasn't taking into account that, within each system, the y-coordinate of the staff may be different.