Fixed off by one error which incorrectly prohibits a tab note moving … #15730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a string at the highest fret.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 9, 2023
…s a tab note moving to a string at the highest fret. Backport of musescore#15730
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jan 9, 2023
…s a tab note moving to a string at the highest fret. Backport of musescore#15730
|
Is there anything else I should do to facilitate the merge? |
|
No :) |
oktophonie
approved these changes
Feb 15, 2023
cbjeukendrup
approved these changes
Feb 16, 2023
This was referenced Feb 16, 2023
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…s a tab note moving to a string at the highest fret. Backport of musescore#15730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to a string at the highest fret.
Resolves: #15729 which was also discussed here.