Fix crash when opening score with instruments without instrumentId and without InstrChannels #16284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbjeukendrup
changed the title
|
Now that I think a bit more about it, I'm wondering how it is possible that these instruments without an ID got written to a 4.0.0 file. You'd say that the ID should be determined when opening the score in 4.0.0+, and then it should be written to the file. |
|
Perhaps the ID was lost as a result of trying to replace the instrument from 4.0, then backing out of the dialog? See #14303 for a report of this losing the mixer channel immediately, and a reference to another report in the forum of this then leading to a crash on save/reload. |
|
Thanks, that sounds very likely. I'll take a look at that issue too. |
RomanPudashkin
approved these changes
Feb 10, 2023
|
@RomanPudashkin - if you're happy, I'm happy to include in the patch release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #16248
Resolves: #16235
Maybe a candidate for the patch release? Two reports already.