Remove hanging ties on XML import #22455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 17, 2024
Backport of musescore#22455, which in turn is a port of musescore#8556 (which got ported to 3.7 earlier), but doesn't replace hanging ties with l.v. articulations, opting instead to simply delete them pending a proper feature.
miiizen
force-pushed
the
xml-hanging-ties
branch
from
ae14d84
to
383b8bf
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 17, 2024
Backport of musescore#22455, which in turn is a port of musescore#8556 (which got ported to 3.7 earlier), but doesn't replace hanging ties with l.v. articulations, opting instead to simply delete them pending a proper feature.
miiizen
force-pushed
the
xml-hanging-ties
branch
from
383b8bf
to
2acfc94
Compare
oktophonie
approved these changes
Apr 18, 2024
mike-spa
reviewed
Apr 18, 2024
| return; | ||
| } | ||
|
|
||
| auto chord = note->chord(); |
There was a problem hiding this comment.
I'm not a fan of "auto". I use it only for complicated types like iterators etc, but when the type is as simple as Chord*, better make it explicit
| if (el && el->isChord()) { | ||
| Note* matchingNote = toChord(el)->findNote(unterminatedTieNote->pitch()); | ||
| if (matchingNote && matchingNote->tpc1() == unterminatedTieNote->tpc1() | ||
| && matchingNote->tpc2() == unterminatedTieNote->tpc2()) { |
There was a problem hiding this comment.
I don't think you need to check both tpc1 and tpc2. As far as I know, the first is the concert pitch version, the latter is the transposed version: if one is equal, the other must be equal too. Perhaps you can simply use note->tpc(), which will choose by itself
miiizen
force-pushed
the
xml-hanging-ties
branch
from
2acfc94
to
fec6551
Compare
mike-spa
approved these changes
Apr 18, 2024
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 18, 2024
Backport of musescore#22455, which in turn is a port of musescore#8556 (which got ported to 3.7 earlier), but doesn't replace hanging ties with l.v. articulations, opting instead to simply delete them pending a proper feature.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 18, 2024
Backport of musescore#22455, which in turn is a port of musescore#8556 (which got ported to 3.7 earlier), but doesn't replace hanging ties with l.v. articulations, opting instead to simply delete them pending a proper feature.
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports some of #8556, but doesn't replace hanging ties with l.v. articulations, opting instead to simply delete them pending a proper feature.
The PR also limits the length of ties. Ties ending in a different bar will only be connected if there are no intermediary notes or rests in a voice which avoids this case (the final A has a tie ending tag).
Dolet 6 doesn't export cross stave information which can lead to unterminated ties. We search for these cases, and if found create cross stave ties:
