Fix #271505: Allow user to set mode along with key signature #3633

Jojo-Schmitz · 2018-04-18T07:02:28Z

MusicXML im- and export of all possible key signatur modes.
Make these availble to the UI, via the Key Signature Inspector. (WIP, it doesn't quite work yet, any idea why?)

marnen · 2018-04-18T07:15:10Z

Oh awesome. Thanks!

lasconic · 2018-04-27T12:06:41Z

libmscore/keysig.cpp

+//   undoSetModeType
+//---------------------------------------------------------
+
+void KeySig::undoSetModeType(KeyMode v)


Why modetype? and not just mode ?

Just because the enum is KEYSIG_MODETYPE. I can change that, no problem

lasconic · 2018-04-27T12:26:21Z

What part is no working specifically? How do you plan to change the mode of C major ?

Jojo-Schmitz · 2018-04-27T12:46:56Z

The dialog in Inspector doesn't work, it doesn't show the mode and doesn't allow to change it

And indeed C-Major / a-minor is a problem. As is open/atonal.
But this problem exists also for courtesy sigs and the ability to switch these on or off

lasconic · 2018-04-27T14:03:29Z

libmscore/keysig.cpp

+            case Pid::KEYSIG_MODETYPE:
+                  if (generated())
+                        return false;
+                  //setModeType(v);


This could be the reason why it's not set by the inspector maybe ?

It is commented out because it doesn't compile ;-)

no known conversion from 'const QVariant' to 'Ms::KeyMode'

lasconic · 2018-04-27T14:13:18Z

mscore/inspector/inspector.cpp

@@ -678,7 +678,8 @@ InspectorKeySig::InspectorKeySig(QWidget* parent)
      const std::vector<InspectorItem> iiList = {
            { Pid::LEADING_SPACE,  1, s.leadingSpace,  s.resetLeadingSpace  },
            { Pid::SHOW_COURTESY,  0, k.showCourtesy,  k.resetShowCourtesy  },
-//          { Pid::SHOW_NATURALS,  0, k.showNaturals,  k.resetShowNaturals  }
+          //{ Pid::SHOW_NATURALS,  0, k.showNaturals,  k.resetShowNaturals  },
+            { Pid::KEYSIG_MODETYPE,0, k.modeType,      k.resetModeType      }


This is not enough to make the combo works. You need to define user data in the combo to match the value of the Keymode enum. If not, MuseScore uses enum value as index void InspectorBase::setValue(const InspectorItem& ii, QVariant val)

OK, this might be it then.

Now at least that menu doesn't start empty, but with "Unknown", still the setting doesn't stick though

lasconic · 2018-04-28T15:59:06Z

libmscore/keysig.cpp

+            case Pid::KEYSIG_MODE:
+                  if (generated())
+                        return false;
+                  //setMode(v);  // no known conversion from 'const QVariant' to 'Ms::KeyMode'


KeyMode(v.toInt()) ?

oops, indeed

Jojo-Schmitz · 2018-04-28T17:17:49Z

Probably case P_TYPE::KEYMODE needs to get added to/dealt with in void XmlWriter::tag()

dmitrio95 · 2019-08-28T08:57:55Z

libmscore/property.cpp

+                              return "major";
+                        case KeyMode::MINOR:
+                              return "minor";
+                        default:


This switch should probably include all the new KeyMode entries too (if this PR is still actual).

Jojo-Schmitz · 2019-08-28T10:51:21Z

Strange, why do I get merge conflicts on rebase, but none are reported here?
Anyway, got it rebased now (conflicts in ui files are a royal pain :-()

Jojo-Schmitz · 2019-08-28T11:41:59Z

Ooops, something went wrong with inspector_keysig.ui...

for MusicXML im- and export of all possible key signatur modes

Jojo-Schmitz · 2019-08-29T15:36:21Z

@anatoly-os I believe the "work in progress" label can get removed

follow up to musescore#3633, there this had been forgotten (by me)

follow up to musescore#3633, there this had been forgotten (by me) Backport of musescore#13060

Jojo-Schmitz force-pushed the keysigmode branch 2 times, most recently from 38938f1 to a04fa52 Compare April 20, 2018 10:59

lasconic reviewed Apr 27, 2018

View reviewed changes

Jojo-Schmitz force-pushed the keysigmode branch from b8fd31b to e631485 Compare April 28, 2018 15:08

lasconic reviewed Apr 28, 2018

View reviewed changes

Jojo-Schmitz force-pushed the keysigmode branch from cec970d to 2fbeb47 Compare April 28, 2018 16:08

Jojo-Schmitz force-pushed the keysigmode branch 2 times, most recently from e5aa6dd to 08d3fae Compare August 8, 2018 08:54

anatoly-os added the work in progress not finished work or not addressed review label Aug 8, 2018

Jojo-Schmitz force-pushed the keysigmode branch from 08d3fae to 1a1ad44 Compare November 8, 2018 12:50

anatoly-os assigned Jojo-Schmitz Nov 14, 2018

Jojo-Schmitz force-pushed the keysigmode branch 2 times, most recently from df6e62e to 04e1c59 Compare November 30, 2018 14:01

Jojo-Schmitz force-pushed the keysigmode branch from 04e1c59 to f3cf2f2 Compare February 5, 2019 13:28

Jojo-Schmitz force-pushed the keysigmode branch from f3cf2f2 to a2cfc2b Compare March 5, 2019 09:44

Jojo-Schmitz force-pushed the keysigmode branch from a2cfc2b to 50a079c Compare April 1, 2019 09:21

Jojo-Schmitz force-pushed the keysigmode branch 2 times, most recently from 13b98c2 to 553677d Compare May 1, 2019 15:32

Jojo-Schmitz force-pushed the keysigmode branch from 553677d to 08c59e9 Compare May 13, 2019 11:49

dmitrio95 reviewed Aug 28, 2019

View reviewed changes

anatoly-os mentioned this pull request Aug 28, 2019

PR candidates to be merged to MuseScore 3.3 Beta #5283

Closed

30 tasks

Jojo-Schmitz force-pushed the keysigmode branch from 08c59e9 to 9e744f1 Compare August 28, 2019 11:36

Jojo-Schmitz force-pushed the keysigmode branch from 9e744f1 to 6b70bd0 Compare August 28, 2019 11:50

Fix #271505: Allow user to set mode along with key signature

1b7d265

for MusicXML im- and export of all possible key signatur modes

Jojo-Schmitz force-pushed the keysigmode branch from 6b70bd0 to 1b7d265 Compare August 28, 2019 16:56

dmitrio95 removed the work in progress not finished work or not addressed review label Aug 29, 2019

dmitrio95 merged commit 5b02dc0 into musescore:master Aug 30, 2019

Jojo-Schmitz deleted the keysigmode branch August 30, 2019 10:11

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 28, 2022

Add missing Aeolian key signature mode

223612c

follow up to musescore#3633, there this had been forgotten (by me)

Jojo-Schmitz mentioned this pull request Aug 28, 2022

[MU4] Add missing Aeolian key signature mode #13060

Merged

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 28, 2022

Add missing Aeolian key signature mode

bf5254f

follow up to musescore#3633, there this had been forgotten (by me) Backport of musescore#13060

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

Add missing Aeolian key signature mode

83e5374

follow up to musescore#3633, there this had been forgotten (by me) Backport of musescore#13060

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #271505: Allow user to set mode along with key signature #3633

Fix #271505: Allow user to set mode along with key signature #3633

Jojo-Schmitz commented Apr 18, 2018 •

edited

Loading

marnen commented Apr 18, 2018

lasconic Apr 27, 2018

Jojo-Schmitz Apr 27, 2018 •

edited

Loading

lasconic commented Apr 27, 2018

Jojo-Schmitz commented Apr 27, 2018 •

edited

Loading

lasconic Apr 27, 2018

Jojo-Schmitz Apr 27, 2018 •

edited

Loading

lasconic Apr 27, 2018

Jojo-Schmitz Apr 27, 2018

Jojo-Schmitz Apr 28, 2018 •

edited

Loading

lasconic Apr 28, 2018

Jojo-Schmitz Apr 28, 2018

Jojo-Schmitz commented Apr 28, 2018

dmitrio95 Aug 28, 2019

Jojo-Schmitz Aug 28, 2019

Jojo-Schmitz Aug 28, 2019

Jojo-Schmitz commented Aug 28, 2019 •

edited

Loading

Jojo-Schmitz commented Aug 28, 2019 •

edited

Loading

Jojo-Schmitz commented Aug 29, 2019 •

edited

Loading

Fix #271505: Allow user to set mode along with key signature #3633

Fix #271505: Allow user to set mode along with key signature #3633

Conversation

Jojo-Schmitz commented Apr 18, 2018 • edited Loading

marnen commented Apr 18, 2018

Choose a reason for hiding this comment

Jojo-Schmitz Apr 27, 2018 • edited Loading

Choose a reason for hiding this comment

lasconic commented Apr 27, 2018

Jojo-Schmitz commented Apr 27, 2018 • edited Loading

Choose a reason for hiding this comment

Jojo-Schmitz Apr 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jojo-Schmitz Apr 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jojo-Schmitz commented Apr 28, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jojo-Schmitz commented Aug 28, 2019 • edited Loading

Jojo-Schmitz commented Aug 28, 2019 • edited Loading

Jojo-Schmitz commented Aug 29, 2019 • edited Loading

Jojo-Schmitz commented Apr 18, 2018 •

edited

Loading

Jojo-Schmitz Apr 27, 2018 •

edited

Loading

Jojo-Schmitz commented Apr 27, 2018 •

edited

Loading

Jojo-Schmitz Apr 27, 2018 •

edited

Loading

Jojo-Schmitz Apr 28, 2018 •

edited

Loading

Jojo-Schmitz commented Aug 28, 2019 •

edited

Loading

Jojo-Schmitz commented Aug 28, 2019 •

edited

Loading

Jojo-Schmitz commented Aug 29, 2019 •

edited

Loading