Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove forgotten comment #6031

Merged
merged 1 commit into from
Jun 22, 2020
Merged

remove forgotten comment #6031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions libmscore/scorefile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,6 @@ bool MasterScore::saveFile(bool generateBackup)
// if file was already saved in this session
// save but don't overwrite backup again

//
// step 2
// remove old backup file if exists
// remove the backup file in the same dir as score (the traditional place) if exists
//
const QString backupSubdirString = preferences.getString(PREF_APP_BACKUP_SUBFOLDER);
const QString backupDirString = info.path() + QString(QDir::separator()) + backupSubdirString;
QDir backupDir(backupDirString);
Expand Down Expand Up @@ -462,8 +457,11 @@ bool MasterScore::saveFile(bool generateBackup)
// tr("Removing old backup file %1 failed").arg(backupName));
}
}
//
// step 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "step 2" should probably remain in the same position.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marr11317 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, I completely forgot that one...
However, I am not sure that it really should. The step has moved, so why keep the name of it at some other place?

// backup files prior to 3.5 were saved in the same directory as the file itself.
// remove these old backup files if needed
//
if (dir != backupDir && dir.exists(backupName)) {
if (!dir.remove(backupName)) {
// if (!MScore::noGui)
Expand Down