Fix #277796: Inconsistent octave selection in note input mode #6052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattmcclinch new script tests could be added to this PR to verify the new behaviour for C major and E-flat Major for example. |
Resolves: https://musescore.org/en/node/277796. Calculate the octave for the new note based on what the previous pitch would have been if it were unmodified by accidental and/or key signature.
mattmcclinch
force-pushed
the
277796-octave-selection
branch
from
b839845
to
0ed9813
Compare
|
@anatoly-os, I added the test. Is this PR still under review? |
29 tasks
anatoly-os
added a commit
that referenced
this pull request
May 25, 2020
Fix #277796: Inconsistent octave selection in note input mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/277796.
Calculate the octave for the new note based on what the previous pitch would have been if it were unmodified by accidental and/or key signature.