fix #305017: Cursor.addNote fails to add notes to existing chords in INPUT_STATE_INDEPENDENT mode #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…INPUT_STATE_INDEPENDENT mode The issue appeared after bd979cf which attempted to decouple the logic behind Cursor.addNote() from InputState in Score::_is to make it possible to choose whether Cursor should be synchronized with score input state. However Score::addNote implicitly contained more dependencies on Score::_is which were not covered by the previous change. This commit is intended to remove this dependency and fix behavior of "independent" mode of Cursor in QML plugins.
2 tasks
anatoly-os
added a commit
that referenced
this pull request
May 12, 2020
…regression fix #305017: Cursor.addNote fails to add notes to existing chords in INPUT_STATE_INDEPENDENT mode
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/305017 (regression after #5657)
The issue appeared after bd979cf which
attempted to decouple the logic behind Cursor.addNote() from InputState
in Score::_is to make it possible to choose whether Cursor should
be synchronized with score input state. However Score::addNote implicitly
contained more dependencies on Score::_is which were not covered by
the previous change. This commit is intended to remove this dependency
and fix behavior of "independent" mode of Cursor in QML plugins.