Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #289952 : gliss. text is misplaced on exporting the score #6064

Merged
merged 1 commit into from
May 18, 2020

Conversation

AntonioBL
Copy link
Contributor

@AntonioBL AntonioBL commented May 8, 2020

Resolves: https://musescore.org/en/node/289952

The "gliss." text width was computed by assuming screen metrics, while exporting (as pdf, svg or png) assumes a DPI value usually different from the screen one.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • (already existing) I created the test (mtest, vtest, script test) to verify the changes I made

@AntonioBL
Copy link
Contributor Author

I am expecting that "gliss-1" vtest should improve with this PR.
(That's why I didn't add an additional vtest)

@AntonioBL
Copy link
Contributor Author

Note: I was misled by Qt documentation: this function https://doc.qt.io/qt-5/qfontmetrics.html#QFontMetrics-2 was not introduced in Qt 5.13 (as stated in the docs). In Qt 5.13 the second argument simply changed to const, but the function was present even before.

@AntonioBL
Copy link
Contributor Author

As an example, gliss-1:
Before
gliss-1-ref
After
gliss-1-1
Diff
gliss-1-diff

@worldwideweary
Copy link
Contributor

worldwideweary commented May 9, 2020

What's up with the CI_vtests/run_vtests error?

@AntonioBL
Copy link
Contributor Author

That's because the behavior of the rendering of some vtests has changed compared to the parent branch. In fact, the positioning with this PR has improved (the "gliss." position is now the same as seen on the screen).

@anatoly-os anatoly-os merged commit b95b3a0 into musescore:3.x May 18, 2020
anatoly-os added a commit that referenced this pull request May 20, 2020
fix #289952 : gliss. text is misplaced on exporting the score
@AntonioBL AntonioBL deleted the glissandotext branch October 26, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants