-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix man-page to mention changed default DPI setting for PNGs export #6066
Conversation
follow up for 2d83656, which changed that from 300 to 72.0 * 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise great.
mscore/musescore.cpp
Outdated
parser.addOption(QCommandLineOption( "score-meta", "Export score metadata to JSON document and print it to stdout")); | ||
parser.addOption(QCommandLineOption( "score-mp3", "Generates mp3 for the given score and export the data to a single JSON file, print it to stdout")); | ||
parser.addOption(QCommandLineOption( "score-parts-pdf", "Generates parts data for the given score and export the data to a single JSON file, print it to stdout")); | ||
parser.addOption(QCommandLineOption( "score-transpose", "Transposes the given score and exports the data to a single JSON file, print it to stdout", "options")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prints
because all other verbs are also in this form
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see "Print...", "Use...", "Start...", "Dump...", "Export...", "Set...", "Specify", "Load...", "Execute...", "Save...", "Revert...", "Process...", "Enable...", "Override...", "Run...", "Don't use...", "Install...".
So the majority is not, but "Used with...", "Generates...", "Transposes", so needs fixing.
So the majority is not, but "Used with...", "Generates...", "Transposes", so needs fixing.
Ah, I looked in the context, which has Generates, Transposes, etc.
OK fix it the other way round then ☻
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
still needed for master too |
fix man-page to mention changed default DPI setting for PNGs export
follow up for 2d83656 (so since MuseScore 3.4), which changed that from 300 to 72.0 * 5