Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #305265: Bracket added from palette only spans one staff regardless of selection #6073

Merged
merged 1 commit into from
May 12, 2020

Conversation

IsaacWeiss
Copy link
Contributor

@IsaacWeiss IsaacWeiss commented May 11, 2020

Resolves: https://musescore.org/en/node/305265

Small usability/workflow improvement so that newly added bracket spans all selected staves. Previously, only the top staff of the selection would get the bracket.

Submitted against 3.x, but should also be cherry-picked to master.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit d5187b8 into musescore:3.x May 12, 2020
@IsaacWeiss IsaacWeiss deleted the 305265-bracket-span branch May 12, 2020 01:53
@Jojo-Schmitz
Copy link
Contributor

needed in master too

anatoly-os added a commit that referenced this pull request May 20, 2020
Fix #305265: Bracket added from palette only spans one staff regardless of selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants