Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #286144 : no or wrong style assigned to texts in parts of 2.x scores #6075

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

AntonioBL
Copy link
Contributor

@AntonioBL AntonioBL commented May 11, 2020

Resolves: https://musescore.org/en/node/286144
(even if that bug is a mixture of this and https://musescore.org/en/node/285434 )

When reading user styles from 2.x scores, the list of used styles was never reset before reading new scores (such as the scores of the different parts, if present). Therefore user-defined styles could be lost for the parts because of "addUserTextStyle: too many user defined textstyles".

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants