Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #305705: part 3, Bouzouki uses metal strings (and some more) #6078

Merged
merged 1 commit into from
May 22, 2020
Merged

fix #305705: part 3, Bouzouki uses metal strings (and some more) #6078

merged 1 commit into from
May 22, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented May 12, 2020 •
edited
Loading

  • As the default and the HQ soundfonts have a sound for 12-string Guitar, this seems an almost perfect match for Bouzouki (using courses rather than strings).
  • Changing that for the 12-string Guitar too, of course.
  • While at it I detected that the default and HQ soundfonts also has sounds for Ukulele and Mandolin, so let's use those too.
  • Also fix some marching band percussion instruments to use the correct soundbank (and the same the Small Marching Band template use already), even if that bank is currently not populated (but is in the latest update to the soundfont), didn't sound before, doesn't sound with the current soundfont (so no harm done) but will with the updated soundfont.

Fixed soundfonts (for those marching band sounds and some more fixes) for the time being available at
https://drive.google.com/file/d/14LgMarbbT98t6AkUhfv7CfJ1S4dx45i-/view?usp=sharing
and the HQ version at
https://drive.google.com/file/d/1QJsN0qojs0GPYlK2oEpb4Z-mPLLdZ6Yj/view?usp=sharing

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 12, 2020
Closed
12 tasks
@MarcSabatella
Copy link
Contributor

Ride cymbal is 51 (53 for ride bell) in the standard instrument, 72 produces no sound for me. Does it for you? According to General MIDI spec, 51 is correct, 72 should be "long whistle" but again I get nothing.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented May 12, 2020 •
edited
Loading

I haven't tried, I just relied on what is used in

MuseScore/share/instruments/instruments.xml

Lines 7009 to 7015 in e925ba0

<Drum pitch="30">
<head>cross</head>
<line>0</line>
<voice>0</voice>
<name>Ride</name>
<stem>1</stem>
</Drum>
for Orchestral Percussion (30), then there's also, Ride Cymbal (72) at

MuseScore/share/instruments/instruments.xml

Lines 7216 to 7221 in e925ba0

<Drum pitch="72">
<head>cross</head>
<line>1</line>
<voice>2</voice>
<name>Ride Cymbal</name>
</Drum>
for Marching Snare Drum, while 51 is Ride Cymbal 1 at

MuseScore/share/instruments/instruments.xml

Lines 6389 to 6396 in e925ba0

<Drum pitch="51">
<head>normal</head>
<line>0</line>
<voice>0</voice>
<name>Ride Cymbal 1</name>
<stem>2</stem>
<shortcut>A</shortcut>
</Drum>

So if 72 doesn't work, instruments.xml needs to get fixed too? To what, 30 or 51?

@MarcSabatella
Copy link
Contributor

Well, I certainly don't get sound for anything other than 51 in the standard kit, which is what is used by default. But some of these instruments define specify alternative kits. With the orchestral percussion instrument, it specifically called for the Orchestra kit, and there, MIDi pitch 30 is used and does seem to work, so I'll assume that's OK as is. But the marching snare calls for a different kit - the Marching Snare kit. At least, that is what actually gets used. In the insturments.xml file itself, I think it's the channel 56 setting that does this.

Unfortunately in the matching snare kit, it doesn't seem 51 does anything, either. My guess is that 72 was supposed to and might have at one time to but somehow that got lost in some revision of the soundfont.

So I think more investigation is needed here - should we really still be relying on this Marching Snare kit, is the problem that the pitch changed or that the sound was removed or what.

@Jojo-Schmitz
Copy link
Contributor Author

So neither 30 nor 51 nor 72 works here?

@Jojo-Schmitz Jojo-Schmitz reopened this May 12, 2020
@Jojo-Schmitz
Copy link
Contributor Author

oops, fat-fingered it

@Jojo-Schmitz Jojo-Schmitz force-pushed the marching-band-templates branch 2 times, most recently from 185d986 to 58f7d2c Compare May 12, 2020 20:13
@Jojo-Schmitz Jojo-Schmitz marked this pull request as draft May 12, 2020 20:14
@Jojo-Schmitz
Copy link
Contributor Author

As per S. Christian Collins this is a defect in the soundfont, so the Small Marching Band template is correct as is. However, the instruments.xml is not, so I'll submit this here

@Jojo-Schmitz
Copy link
Contributor Author

Dang!

@Jojo-Schmitz Jojo-Schmitz reopened this May 13, 2020
@Jojo-Schmitz Jojo-Schmitz marked this pull request as ready for review May 13, 2020 14:18
@Jojo-Schmitz Jojo-Schmitz changed the title fix #305308: Small Marching band snare drum Hi-Hats don't sound Fix some marching band percussion instruments to use the correct soundbank May 13, 2020
@Jojo-Schmitz Jojo-Schmitz changed the title Fix some marching band percussion instruments to use the correct soundbank fix #305705: part 3, Bouzouki uses metal strings (and some more) May 22, 2020
@Jojo-Schmitz
fix #305705: part 3, Bouzouki uses metal strings (and some more)
9b93615 
As the HQ soundfont has a sound for 12-string Guitar, this seems an
almost perfect match for Bouzouki (using courses rather than strings
too)
Changing that for the 12-string Guitar too, of course.
While at it I detected that the HQ soundfont also has sounds for Ukulele
and Mandolin, so let's use those too (and fall back to nylon strings
otherwise).
Also fix some marching band percussion instruments to use the correct
soundbank (and the same the Small Marching Band template use already)
even if that bank is currently not populated (but is in the latest
update to the soundfont), didn't sound before, doesn't sound with the
current soundfont (so no harm done) but will with the updated soundfont
@anatoly-os anatoly-os merged commit 38b0bdc into musescore:3.x May 22, 2020
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request May 22, 2020
Closed
29 tasks
@Jojo-Schmitz Jojo-Schmitz deleted the marching-band-templates branch May 22, 2020 12:23
anatoly-os added a commit that referenced this pull request May 25, 2020
@anatoly-os
Merge pull request #6078 from Jojo-Schmitz/marching-band-templates
c121eef 
fix #305705: part 3, Bouzouki uses metal strings (and some more)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jojo-Schmitz @MarcSabatella @anatoly-os