Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #305724: Disable save prompt for empty scores #6106

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented May 21, 2020

Resolves: #305724

Added logic to disable the save prompt for empty scores; i.e., scores that were automatically created at startup using the “Start with score” feature and that don't contain any modifications.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

mscore/musescore.cpp Outdated Show resolved Hide resolved
@Spire42 Spire42 force-pushed the 305724-disable-save-prompt-for-empty-scores branch from 0bedef7 to d376a87 Compare May 21, 2020 16:19
mscore/file.cpp Show resolved Hide resolved
Added logic to disable the save prompt for empty scores; i.e., scores that were automatically created at startup using the “Start with score” feature and that don't contain any modifications.
@Spire42 Spire42 force-pushed the 305724-disable-save-prompt-for-empty-scores branch from d376a87 to a8d510a Compare May 28, 2020 11:24
@Spire42
Copy link
Contributor Author

Spire42 commented May 28, 2020

That last force-push was just to clarify a few comments inside MuseScore::closeEvent() (no changes to actual code).

@Spire42 Spire42 mentioned this pull request May 28, 2020
12 tasks
@anatoly-os anatoly-os merged commit c7fb591 into musescore:3.x Jun 2, 2020
anatoly-os added a commit that referenced this pull request Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants