fix #305745: playback of "add" chords #6107
Conversation
|
forcing a new build should sort that Travis failure |
I think only if Marc also rebases the PR on top of the updated 3.x branch. |
|
May be needed, indeed. ISTR remember though that for other PRs just rebuilding helped too |
|
@MarcSabatella nope, just restarted the build again. You can try to rebase this PR on top of later 3.x. But afaiu, Travis builds PRs on top of the latest commit of the parent branch. |
|
That is indeed what I believe to have seen with some other PRs |
|
I see mtest failures that I need to investigate, could be I broke something, could be some refs need updating. |
|
Yes, the ones now are all your's |
|
I see what's happening. It's really an underlying bug that was being masked before. Will have a fix today or tomorrow. |
The algorithm for constructing the realized harmony for a chord symbol was missing a handler for the "add" keyword. Additions can also be specified using parensthesis, but this yields an spurious assertion failure in debug mode, so that is fixed here as well.
MarcSabatella
force-pushed
the
305745-play-add-chords
branch
from
acef737
to
510f012
Compare
|
@MarcSabatella ? :) |
|
I pushed the fix already, tests are passing, should be good to merge. |
The algorithm for constructing the realized harmony for a chord symbol
was missing a handler for the "add" keyword.
Additions can also be specified using parentheses,
but this yields a spurious assertion failure in debug mode,
so that is fixed here as well.
Resolves: https://musescore.org/en/node/305745