Fix #305750 - Nested tuplets in linked staves lead to corruption #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing algorithm had problems finding the correct linked tuplets when dealing with linked staffs. The algorithm is now looking for tuplet, linked to tuplet of the orginal chordrest but on the same staff as the newly created chordrest.
This was referenced May 25, 2020
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Jul 23, 2020
Fix #305750 - Nested tuplets in linked staves lead to corruption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/305750
Existing algorithm had problems finding the correct linked tuplets when dealing with linked staffs.
The algorithm is now looking for
Tupletlinked toTupletof the originalChordRestbut on the same staff as the newly createdChordRest.This PR is related to, but not the same as PR #6049. Both are solving another issues with linked staffs.