Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #304843 - Brackets displaced in Continuous View #6132

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented May 28, 2020

Resolves: https://musescore.org/en/node/304843

Call to layoutSystem() in Score::collectLinearSystem() didn't take the existence of a HBOX into account. Instead of fixed 0.0, now the shift due to the HBox is passed.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Call to layoutSystem() in Score::collectLinearSystem() didn't take the
existance of a HBOX into account. Instead of fixed 0.0 now the shift
due to the HBox is passed.
@anatoly-os anatoly-os merged commit 7952f0c into musescore:3.x Jun 1, 2020
@njvdberg njvdberg deleted the issue-304843-brackets-displaces branch June 2, 2020 07:52
anatoly-os added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants