fix #304051: repeat single note in normal mode #6140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
njvdberg
approved these changes
May 29, 2020
mscore/scoreview.cpp
Outdated
| return; | ||
| ChordRest* cr = _score->getSelectedChordRest(); | ||
| if (!cr) | ||
| return; |
There was a problem hiding this comment.
4 space indent here, but 6 else?
There was a problem hiding this comment.
Arrgh! I set up a new build environment and hadn't bothered installing my usual formatting because I knew it was changing, so I was using the QtCreator defaults and fixing them manually. Missed this one, thanks for catching. Harmless in the end I guess, but still...
Resolves: https://musescore.org/en/node/304051 Lately there has been much discussion of the "R" command and the fact that it only works on range selections. In Sibelius, the same command is more general. While it's not obvious what results might be expected in each and every case, the most important request here has been for "R" to work with a single note selected (not a range). This change implements that very simply by checking for this case and creating a range selection first. Currently we generate a debug error message then simply do nothing. So the change does not change anything about how the command works except to allow it to do something reasonable in the case of a single note/rest selected. Note because a range selection is created, this means selecting a single note in a chord repeats the whole chord. That is how the command works in note input mode, and it is how Sibelius works.
MarcSabatella
force-pushed
the
304051-repeat-note
branch
from
75ced00
to
7312b63
Compare
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/304051
Lately there has been much discussion of the "R" command
and the fact that it only works on range selections.
In Sibelius, the same command is more general.
While it's not obvious what results might be expected
in each and every case, the most important request here
has been for "R" to work with a single note selected (not a range).
This change implements that very simply by checking for this case
and creating a range selection first.
Currently we generate a debug error message then simply do nothing.
So the change does not change anything about how the command works
except to allow it to do something reasonable
in the case of a single note/rest selected.
Note because a range selection is created, this means
selecting a single note in a chord repeats the whole chord.
That is how the command works in note input mode,
and it is how Sibelius works.