Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] [WIP] GSoC 2020: Albums #6145

Closed
wants to merge 72 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
8a2618f
squash for appveyor
SKefalidis Aug 17, 2020
3c5317d
fixed currentScoreView updated correctly when switching between excerpts
SKefalidis Aug 18, 2020
fec2ce2
fixed crash on close album
SKefalidis Aug 18, 2020
70c54f3
possible fix-workaround for session restore related crashes
SKefalidis Aug 18, 2020
fb81b3d
fix paint crash
SKefalidis Aug 18, 2020
4b77f01
fix albummanagerdialog with no album loaded
SKefalidis Aug 18, 2020
0b4e595
fixed albummanager window calls hide event when changing workspace
SKefalidis Aug 18, 2020
84fb2ba
drawFrontCover
SKefalidis Aug 18, 2020
9b91786
album title loaded
SKefalidis Aug 18, 2020
d523980
modified PR #6352
SKefalidis Aug 18, 2020
e7a357a
contents pages
SKefalidis Aug 18, 2020
7c73ac7
fixed crash when adding scores with different instrumentation on new …
SKefalidis Aug 18, 2020
97bf3d3
read + collect_artifacts
SKefalidis Aug 18, 2020
0b8f961
enable albumBreaks test
SKefalidis Aug 19, 2020
795975c
default pause and mass change pause
SKefalidis Aug 19, 2020
55b98ff
fixed problems related to restore session? (finally?)
SKefalidis Aug 19, 2020
4afd0c3
codestyle
SKefalidis Aug 19, 2020
14ccf0f
use albumScores() instead of x->score
SKefalidis Aug 19, 2020
8cb1477
tests for legacy albums
SKefalidis Aug 19, 2020
4830468
simplified and improved playback control
SKefalidis Aug 19, 2020
b849f05
fixed seq crash
SKefalidis Aug 20, 2020
ffd606e
fixed restore session
SKefalidis Aug 20, 2020
061bc0f
export parts
SKefalidis Aug 21, 2020
8bba733
at last good playback!!!
SKefalidis Aug 20, 2020
926d28e
fixed crashes related to deleted Album pages
SKefalidis Aug 21, 2020
fbef035
codestyle
SKefalidis Aug 22, 2020
236ef30
cleanup + small things
SKefalidis Aug 22, 2020
77bdef8
fix build failure + codestyle
SKefalidis Aug 22, 2020
94b1551
forgot this file
SKefalidis Aug 22, 2020
4f8de6f
fixed mtests
SKefalidis Aug 22, 2020
c091e52
fixed mtest failure
SKefalidis Aug 22, 2020
e74bd7b
readme
SKefalidis Aug 22, 2020
e4bd9f3
more cleanup and shorter mtest-scores
SKefalidis Aug 22, 2020
f475a7c
forgot this again
SKefalidis Aug 22, 2020
b8d8d3e
correct undo
SKefalidis Aug 23, 2020
53de267
fixed various issues
SKefalidis Aug 23, 2020
b52a166
updateContents when disabling, crash fixes, drawFrontCover in .msca
SKefalidis Aug 23, 2020
2344b46
disabled Album Manager playback
SKefalidis Aug 23, 2020
34ab37e
updated tests
SKefalidis Aug 24, 2020
f514ce1
crash fixes
SKefalidis Aug 24, 2020
e049f01
fixed warning + less doLayout calls
SKefalidis Aug 24, 2020
8670a6e
fixed parts editing + shadownote for parts
SKefalidis Aug 24, 2020
af71887
comments
SKefalidis Aug 24, 2020
a0d052b
codestyle
SKefalidis Aug 24, 2020
1bc0991
rename and comments
SKefalidis Aug 25, 2020
63b014f
a few got left behind
SKefalidis Aug 25, 2020
08cf170
codestyle
SKefalidis Aug 25, 2020
77685c4
rename, delete old code, simplify
SKefalidis Aug 25, 2020
1459521
codestyle
SKefalidis Aug 25, 2020
013e4a2
a bunch of contents and renames
SKefalidis Aug 25, 2020
1fae862
forgot a couple of things
SKefalidis Aug 25, 2020
ebba1df
updated text and readme
SKefalidis Aug 25, 2020
f0a8464
changed how scores are deleted and forgot this
SKefalidis Aug 26, 2020
54debad
fix crash by resetting tempScoreTabindex when closing an album
SKefalidis Aug 26, 2020
64e098c
another small fix
SKefalidis Aug 26, 2020
5a05400
fix crash when drag&drop with disabled movements, added support for e…
SKefalidis Aug 26, 2020
5c9edff
readme
SKefalidis Aug 26, 2020
79c2d5e
removed text
SKefalidis Aug 26, 2020
6488d88
fixed editing parts and updating the view when editing them
SKefalidis Aug 26, 2020
4a7f767
parts scoreview constraints
SKefalidis Aug 26, 2020
5f96cbe
final touches
SKefalidis Aug 30, 2020
9b0524c
readme
SKefalidis Aug 30, 2020
3cea653
codestyle
SKefalidis Aug 30, 2020
d18a6cd
fix travis failure
SKefalidis Aug 31, 2020
bf5db99
FIRST COMMIT AFTER GOOGLE SUMMER OF CODE:\
SKefalidis Sep 1, 2020
6e6ec9b
text styles for front cover and contents wip
SKefalidis Sep 1, 2020
98efe2b
text styles for front cover and contents
SKefalidis Sep 6, 2020
cff3e3f
fixed rebase
SKefalidis Sep 6, 2020
e49d71a
removed unused variable
SKefalidis Sep 6, 2020
41c9de3
codestyle
SKefalidis Sep 6, 2020
6390f10
fixed build failure
SKefalidis Sep 6, 2020
7087861
preferences
SKefalidis Sep 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions albums_readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
Notes:

Today:
- preferences (almost done, only got to load them)
- tests (almost done, maybe combine the tests?)
- undo teleporting!!! (fixed?)
- contents pages broken, because when I addClicked an existing score it adds the exact same masterscore twice in the album
- repositioning an album and being unable to open a score should give a prompt to select the score in the filesystem
- Add the new members of MasterScore/Score to clone functions and save/write?
- Git cleanup.

Tests:
- compressed album file Test (almost done)

Week 4:
Mass changes:
- Mass changes, Actions menu, used by both albums and groups of normal scores (multible tabs selected or opened scores)
- Easy way to select multiple scores.
- Actions:
- Add - Replace instruments.
- Change style.
- Change footers/headers.

Week 5+ (further improvements):
Mixer for album-mode (with all the instruments).
Parts with different instrumentation.
Timeline for the entire Temporary Album Score.
Albums inside an Album.
Tools to split a score into multiple scores (an album).
Improved composer/lyricist handling. Give the user an option in the inspector to include (or not) that string in the front cover.
Add new movement with the same instrumentation as the last one in the album


Refactor and Code Quality:
- Decouple albums and multi movement scores.

Bugs:
- Fix all the places where inActiveAlbum should be inActiveAlbum and the dominantScore is the one in the scoreview (e.g. the teleporting stuff, sequencer setScoreView)
- Crash when editing title of part
- crashes related to text (are this all on master?)
6 changes: 6 additions & 0 deletions framework/preferencekeys.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#define PREF_EXPORT_PDF_DPI "export/pdf/dpi"
#define PREF_EXPORT_PNG_RESOLUTION "export/png/resolution"
#define PREF_EXPORT_PNG_USETRANSPARENCY "export/png/useTransparency"
#define PREF_EXPORT_INCLUDE_ABSOLUTE_PATHS "export/album/includeAbsolutePaths"
#define PREF_IMPORT_GUITARPRO_CHARSET "import/guitarpro/charset"
#define PREF_IMPORT_MUSICXML_IMPORTBREAKS "import/musicXML/importBreaks"
#define PREF_IMPORT_MUSICXML_IMPORTLAYOUT "import/musicXML/importLayout"
Expand Down Expand Up @@ -179,6 +180,11 @@
#define PREF_UI_INSPECTOR_STYLED_TEXT_COLOR_DARK "ui/inspector/styledtext/color/dark"
#define PREF_UI_AVSOMR_RECOGNITION_COLOR "ui/avsomr/recognition/valid/color"
#define PREF_UI_AVSOMR_NOT_RECOGNITION_COLOR "ui/avsomr/recognition/notValid/color"
#define PREF_ALBUM_TITLE_AT_BOTTOM_ALLOWED "album/titleAtTheBottomAllowed"
#define PREF_ALBUM_DRAW_FRONT_COVER "album/drawFrontCover"
#define PREF_ALBUM_GENERATE_CONTENTS "album/generateContents"
#define PREF_ALBUM_PAGE_BREAKS_ENABLED "album/pageBreaks"
#define PREF_ALBUM_DEFAULT_PAUSE_DURATION "album/defaultPauseDuration"
#define PREF_PAN_SMOOTHLY_ENABLED "smoothPan/enabled"
#define PREF_PAN_MODIFIER_BASE "smoothPan/modifier/baseSpeed"
#define PREF_PAN_MODIFIER_STEP "smoothPan/modifier/step"
Expand Down
3 changes: 2 additions & 1 deletion libmscore/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ add_library (
${_all_h_file}
${INCS}

types.h accidental.h ambitus.h arpeggio.h articulation.h audio.h bagpembell.h barline.h beam.h bend.h
types.h accidental.h album.h ambitus.h arpeggio.h articulation.h audio.h bagpembell.h barline.h beam.h bend.h
box.h bracket.h bracketItem.h breath.h bsp.h bsymbol.h changeMap.h chord.h chordline.h chordlist.h chordrest.h clef.h
cleflist.h connector.h drumset.h dsp.h duration.h durationtype.h dynamic.h element.h
elementmap.h excerpt.h fermata.h fifo.h figuredbass.h fingering.h fraction.h fret.h glissando.h groups.h hairpin.h
Expand Down Expand Up @@ -102,6 +102,7 @@ add_library (
scorediff.cpp
unrollrepeats.cpp
preferences.cpp
album.cpp
)

set (LINK_LIBS )
Expand Down
Loading