Fix #303799 - Crash when starting MuseScore after compare score #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed three IF_ASSERTS_FAILED because in these situations a failed assertion is a valid condition which happens when MuseScore is started with the Score Comparison tool open. In this case there are even no files loaded so the assertions cannot be met.
2 tasks
Spire42
reviewed
Jun 5, 2020
| @@ -146,7 +146,7 @@ ScoreView* ScoreTab::view(int n) const | |||
| QSplitter* ScoreTab::viewSplitter(int n) const | |||
| { | |||
| const TabScoreView* tsv = tabScoreView(n); | |||
| IF_ASSERT_FAILED(tsv) { | |||
| if(!tsv) { | |||
There was a problem hiding this comment.
This should have had a space after the if, but I guess I'm too late.
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/303799
Removed three
IF_ASSERTS_FAILEDbecause in these situations a failedassertion is a valid condition which happens when MuseScore is started with the Score Comparison tool open. In this case there are even no files loaded so the assertions cannot be met.