fix #306438: wrong default offset for chord symbols on fret diagrams #6178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/306438 The issue was introduced with a fix for https://musescore.org/en/node/304057, but the fix was too broad: it eliminated all reset of offset for harmony objects on fret diagrams. The original problem was we *always* reset it, the fix was to *never* reset it. The right answer is to reset it if styled. Then manual adjustments are preserved, but if no manual adjustments are present, we reset it - which is to say, set is to the style default.
2 tasks
anatoly-os
added a commit
that referenced
this pull request
Jun 8, 2020
fix #306438: wrong default offset for chord symbols on fret diagrams
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/306438
The issue was introduced with a fix for
https://musescore.org/en/node/304057,
but the fix was too broad: it eliminated all reset of offset
for harmony objects on fret diagrams.
The original problem was we always reset it,
the fix was to never reset it.
The right answer is to reset it if styled.
Then manual adjustments are preserved,
but if no manual adjustments are present,
we reset it - which is to say, set is to the style default.