Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #302573 - Crash undoing add instruments #6183

Merged

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Jun 8, 2020

Resolves: https://musescore.org/en/node/302573

Root cause was in <code<needViewportMove() which used the begin and end staff from the cmdState but the state wasn't adapted for the removed staff yet.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Root cause was in needViewportMove() which used the begin and end staff
from the cmdState but the state wasn't adapted for the removed staff yet.
@njvdberg njvdberg mentioned this pull request Jun 9, 2020
12 tasks
@anatoly-os anatoly-os merged commit 13793f9 into musescore:3.x Jun 9, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…ments

Fix #302573 - Crash undoing add instruments
@njvdberg njvdberg deleted the issue-302573-crash-undo-instruments branch June 10, 2020 10:07
anatoly-os added a commit that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants