fix #305293: crash on load of score with missing drumset #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/305293 We have many crashes with a stack trace showing a bad drumset when calculating a custom notehead. I don't know how these scores got into this state (unless the user deliberately unchecked Drumset in the Mixer), but I know we can prevent the crash by returning a default notehead when the drumset is missing. The drumset will still be missing, so the user will need to do a change isntrument to set it up again, but it beats a crash.
12 tasks
anatoly-os
added a commit
that referenced
this pull request
Jun 10, 2020
fix #305293: crash on load of score with missing drumset
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/305293
We have many crashes with a stack trace showing a bad drumset
when calculating a custom notehead.
I don't know how these scores got into this state
(unless the user deliberately unchecked Drumset in the Mixer),
but I know we can prevent the crash
by returning a default notehead when the drumset is missing.
The drumset will still be missing,
so the user will need to do a change isntrument to set it up again,
but it beats a crash.