Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306512: Improvements to the splash screen #6187

Merged

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Jun 9, 2020

Resolves: #306512

Rewrote the splash-screen code so that it renders everything on the fly using vector graphics instead of using pre-rendered images.

Also designed and implemented a darker version of the splash screen that is automatically used for unstable/development builds.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Spire42 Spire42 mentioned this pull request Jun 9, 2020
12 tasks
@mattmcclinch
Copy link
Contributor

If you rename Maintenance.svg to maintenance.svg, this might actually build on filesystems where case matters.

@Spire42 Spire42 force-pushed the 306512-improvements-to-the-splash-screen branch from 2aba6c3 to 2ca581b Compare June 9, 2020 14:27
@Spire42
Copy link
Contributor Author

Spire42 commented Jun 9, 2020

Thanks; fixed.

@Jojo-Schmitz
Copy link
Contributor

Now Travis CI got lost once again

@Spire42 Spire42 force-pushed the 306512-improvements-to-the-splash-screen branch from 2ca581b to ab7fc5d Compare June 9, 2020 15:34
@Spire42 Spire42 force-pushed the 306512-improvements-to-the-splash-screen branch 2 times, most recently from c0e9777 to ac79263 Compare June 9, 2020 19:18
Rewrote the splash-screen code so that it renders everything on the fly using vector graphics instead of using pre-rendered images.

Also designed and implemented a darker version of the splash screen that is automatically used for unstable/development builds.
@Spire42 Spire42 force-pushed the 306512-improvements-to-the-splash-screen branch from ac79263 to a693441 Compare June 9, 2020 20:09
@ecstrema
Copy link
Contributor

ecstrema commented Jun 9, 2020

Would someone mind posting a screenshot? :)

@mattmcclinch
Copy link
Contributor

Stable version:
stable
Unstable version:
unstable

@anatoly-os anatoly-os merged commit aaba461 into musescore:3.x Jun 10, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…sh-screen

Fix #306512: Improvements to the splash screen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants