fix #306234: added teleportation to smooth scrolling, for dealing with repeats + improved comments #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SKefalidis thank you for the fix! Could you please create new PR containing both this and #6192 on top of This PR can be kept and rebased. I'll merge it to master branch. |
7 tasks
|
@anatoly-os rebased this and created #6193 |
29 tasks
anatoly-os
reviewed
Jul 22, 2020
mscore/scoreview.cpp
Outdated
| @@ -714,6 +714,7 @@ void ScoreView::moveControlCursor(const Fraction& tick) | |||
| } | |||
| _timeElapsed += addition; | |||
| } else { // reposition the cursor when the score is not playing | |||
| std::cout << "here" << std::endl; | |||
There was a problem hiding this comment.
@SKefalidis Could you please delete this?
…h repeats + improved comments
|
If anybody can explain the test failures I would be grateful. They seem to think that I changed parts of the code that I did not change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/306234
Added teleportation (with options to enable/disable in the preferences) to deal with repeats. I also improved the comments.